Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View does not check for target folder existence before moving #27376

Closed
2 tasks
PVince81 opened this issue Mar 13, 2017 · 2 comments
Closed
2 tasks

View does not check for target folder existence before moving #27376

PVince81 opened this issue Mar 13, 2017 · 2 comments

Comments

@PVince81
Copy link
Contributor

Discovered here: #26653 (comment)

Do a cross-storage move with a root view: $view->rename('test1/files/something', 'test2/files/unexist/something') where "unexist" is a non-existing folder.

The view will happily move "something" there but will create a hole in the oc_filecache when trying to attach "something" to its parent with an id -1.

Setting to medium for now as the bug as not been found in a real environment and only during development.

  • write unit test to reproduce the issue
  • fix the issue, return false if the target parent does not exist

cc @jvillafanez @IljaN FYI

@ownclouders
Copy link
Contributor

Hey, this issue has been closed because the label status/STALE is set and there were no updates for 7 days. Feel free to reopen this issue if you deem it appropriate.

(This is an automated comment from GitMate.io.

@lock
Copy link

lock bot commented Jul 31, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants