Can not download multiple times from public page

[nickvergessen]

Steps

1. Share a folder with multiple files as link
2. Open public link
3. Select more then one file from the list
4. Press Download

Expected

Can press download again

Actual

Button is "disabled"

Works fine in 8.1

@PVince81 maybe something for you while you are in your JS phase 😉

[PVince81]

I'll have a look.

CC @MorrisJobke who introduced the spinner recently

[PVince81]

It looks like public download doesn't set the magic cookie so we cannot know when the download started. From what I remember this used to work ?

[PVince81]

The cookie is only set in "files/ajax/download.php" while the public page goes through an app framework controller for the download.

From reading the code it looks like this never could work, at least not since we have the controllers.

[PVince81]

@DeepDiver1975 not a regression. I just checked the git history and this feature has only be added in 8.2. I mistakenly thought that @MorrisJobke backported it

[PVince81]

Fix is here #19643

[DeepDiver1975]

Works fine in 8.1

worked before and now it's broken -> regression for me

[nickvergessen]

Well, the cookie is not in 8.1 right, but in 8.1 you can press the dl button multiple times without a page reload

[PVince81]

fine