Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC5 beta2 - session timeout locks owncloud access only after trying to continue ownCloud usage #1934

Closed
j-ed opened this issue Feb 26, 2013 · 7 comments

Comments

@j-ed
Copy link
Contributor

j-ed commented Feb 26, 2013

From my understanding the session timeout has been introduced as a security mechanism to lock ownCloud access after a defined non-usage period. Unfortunately this function is only triggered if you want to continue to use ownCloud and not instantly after the time has been elapsed. This allows everyone to see the content currently displayed on the screen as long as a function within ownCloud is selected.
I would recommend to change the session timeout function in that way as online banking applications are doing it. A short time before the session timeout is reached, e.g.only 30s left, a message should be shown that the application will be locked if no interaction happens within the next 30s. After the session has been finaly been timed-out a redirect to the login page should happen automatically.
If possible a message should be shown above the login window statting that an automatic logout has been forced due to user inactivity.

@BernhardPosselt
Copy link
Contributor

What do you mean by "only after trying to continue ownCloud usage"

@BernhardPosselt
Copy link
Contributor

Possible relation to #527 ?

@j-ed
Copy link
Contributor Author

j-ed commented Feb 26, 2013

What do you mean by "only after trying to continue ownCloud usage"

As explained before it is more or less how user expectations are
managed. If a session times out I would expect that a redirect to the
login page will happen so that it is clear that a logout has taken
place and that you have to reenter your credentials, similar as your
desktop screen will be locked after you've left your PC for a while.
If that redirect takes place in the moment you want to continue to
work it is noticed as a annoying and disturbing function and not as a
security feature.

@karlitschek
Copy link
Contributor

Definitely a good idea but more an enhancement and not a bug.

@BernhardPosselt
Copy link
Contributor

Problem is this section in lib/base.php

        // session timeout
        if (isset($_SESSION['LAST_ACTIVITY']) && (time() - $_SESSION['LAST_ACTIVITY'] > 3600)) {
            if (isset($_COOKIE[session_name()])) {
                setcookie(session_name(), '', time() - 42000, '/');
            }
            session_unset();
            session_destroy();
            session_start();
        }
        $_SESSION['LAST_ACTIVITY'] = time();

@ghost ghost assigned BernhardPosselt Feb 26, 2013
@BernhardPosselt
Copy link
Contributor

That issue is bugging me a lot, i'll try to get a polling service up and running.

@BernhardPosselt
Copy link
Contributor

Please reopen if the pull request didnt fix this

@lock lock bot locked as resolved and limited conversation to collaborators Aug 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants