Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder size propagation not triggered by Webdav upload #18006

Closed
PVince81 opened this issue Jul 31, 2015 · 5 comments · Fixed by #18030
Closed

Folder size propagation not triggered by Webdav upload #18006

PVince81 opened this issue Jul 31, 2015 · 5 comments · Fixed by #18030

Comments

@PVince81
Copy link
Contributor

Steps to reproduce

  1. Create a folder "test"
  2. Using a Webdav client (I used cadaver), upload a file "pic.jpg" into "test"
  3. In the web UI, check the size of the folder "test"

Expected result

Folder size is updated to reflect the size of the picture inside.

Actual result

Folder size is still zero.

I noticed that in the database the propagation isn't happening after upload.
However the folder size will update itself later through other mechanisms, possibly through PROPFINDs or the scanner that the web UI triggers (ajax/scan.php) or the background cron scan.

This also means that the quota value (the total used space) will not be updated directly.

Uploading through the web UI properly propagates the sizes, so it's specific to Webdav.

Versions

stable8.1 (a9524e2)

I will bisect to find out when this regression was introduced.
Not sure how critical. Setting to 8.1.1 now but 8.1.2 might be fine.

@DeepDiver1975 @icewind1991 @schiesbn

@PVince81 PVince81 added this to the 8.1.1-current-maintenance milestone Jul 31, 2015
@PVince81 PVince81 self-assigned this Jul 31, 2015
@PVince81
Copy link
Contributor Author

Regression from v8.0.5 where it worked properly.

I suspect it might be related to the recent improvements on etag propagation.
The bisect will tell.

@PVince81
Copy link
Contributor Author

I knew it... it's the "work directly on storage when doing webdav PUT": #12006

@PVince81
Copy link
Contributor Author

Note: this will only affect files uploaded without chunking, since the chunking code doesn't work directly on storages (but it will eventually as per #17104)

@ghost ghost modified the milestones: 8.1.2-next-maintenance, 8.1.1-current-maintenance Jul 31, 2015
@PVince81 PVince81 removed their assignment Aug 3, 2015
@PVince81
Copy link
Contributor Author

PVince81 commented Aug 3, 2015

@icewind1991 can you fix this ? Thanks.

@PVince81
Copy link
Contributor Author

PVince81 commented Aug 3, 2015

Alternative for the future: update folder size in a background job: #18028

@lock lock bot locked as resolved and limited conversation to collaborators Aug 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants