Properly lock share owner parent folders

[PVince81]

Steps

1. Enable transactional locking
2. Create users "user1" and "user2"
3. Login as "user1"
4. Create a folder "sub/sub2/folder"
5. Share "sub/sub2/folder" with "user2"
6. Login as "user2"
7. Create a file in "/folder/test.txt" with WebDAV (use slow upload by adding sleep(30) here https://github.com/owncloud/core/blob/master/lib/private/connector/sabre/file.php#L204)
8. During the upload, login as "user1" and rename "sub"

Expected result

"sub" is locked

Actual result

Rename succeeds.

Versions

ownCloud 8.1 git master (58439c3)

Concern raised by @icewind1991

When the parent folders of "test.txt" are selected to be locked in the owner's tree, they are only selected up to the parent root, which is "sub/sub2/folder". The correct behavior would be to also lock "sub/sub2" and "sub".

@icewind1991 said he was working on a POC and possible fix. The idea would be that whenever a shared storage root is being locked, the storage will automatically lock the parents in the original storage.

CC @jnfrmarks @SergioBertolinSG FYI about this test case

[jnfrmarks]

@jvillafanez

JP, can we automate this test case with smashbox?

[jvillafanez]

In fact we should automate all actions over shared files. It's pending to be automated

[PVince81]

PR is here #17246

[PVince81]

@cmonteroluque @karlitschek @DeepDiver1975 moving to 8.1.1.

Needed to make locking more watertight.
See the reproduction steps for a better understanding where the lock is missing in a sharing case.

[MorrisJobke]

@PVince81 I added this issue to 8.2 milestone and added a backport label to the PR. Once the backport against 8.1.1 is done this ticket will get the 8.1.1 brown label ;)