-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't migrate encryption keys (oc7 -> oc8) for users using IMAP auth. #16310
Comments
Hmm .... we need to have a look into this. Note to self: just another case of we-need-one-central-user-table-in-the-db |
No. We need code, that properly uses the public APIs for retrieval of users and not some "we use simple SQL, because it's the way we did it 10 years ago so it should work" |
Looks good so far in the migration code:
|
Also the backend setup looks good: Line 170 in 5f66f86
|
@icewind1991 Do you want to check what is broken here? |
Most probably the app is not loaded. |
Morris: think before rant please. We had issues in this area with many user backends. The issue is bigger then publuc apis. Operations like this key migration or counting users in group etc rely on the backend being available at any time - temporary downtime in such scenarios are dangerous. We discussed this already in the past: all user information has to available at any time under any condition. Therefore we need s central storage of user data. |
The app (external user backed) seems to be on. At least thats what occ says. I do red somewhwere that backends are off while in maintenance mode although I'm not sure of that statement. |
I guess a central storage isn't possible, but rather the backends need to add this caching mechanism to provide the needed info when the backend service isn't available. Or is this also bad? |
The central storage is possible. As soon as a user authenticates we can add the one to a new table - let's call it oc-accounts. This table can then hold further information about a user like display name, email, auth backends and so on. In case an auth backend is offline we still know the user and can act accordingly. |
in that case if the server is in maintenance mode is the external user backend off or not? occ says it is enabled but I'm not so sure. If so, can the migration be run on the server with maintenance mode on. |
if I try to migrate the keys with maintenance mode off i get:
|
@muppeth is this still an issue with more recent versions ? |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Like in the title. I tried migrating keys using occ but seems like the only table being used is oc_users. All my users use user_external (IMAP authentication) so they are in oc_users_external. Any hint on how to modify migration script to look at other table? where is the script located?
The text was updated successfully, but these errors were encountered: