Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt l10n.pl to also parse translations in handlebars templates #15106

Closed
PVince81 opened this issue Mar 23, 2015 · 5 comments
Closed

Adapt l10n.pl to also parse translations in handlebars templates #15106

PVince81 opened this issue Mar 23, 2015 · 5 comments
Labels
comp:core-js enhancement status/STALE
Milestone
maybe some day

Comments

@PVince81
Copy link
Contributor

PVince81 commented Mar 23, 2015 •
edited by DeepDiver1975
Loading

This ticket https://github.com/owncloud/core/pull/14925/files#diff-c428169f7899b3a581d46ca00ce88080R18 will add a new helper for translations in handlebars templates.

These should also be parsed properly by the l10n.pl script (at least once that PR is merged)

@DeepDiver1975
@DeepDiver1975
Copy link
Member

hmm - I doubt that gettext has any idea about handlebars ..... can we either inject the translation strings in php or js?

@PVince81
Copy link
Contributor Author

Are you saying that parsing $l->l10n('') and t() is a feature of gettext ?

We might be able to inject the text using template variables, but that somewhat defies the purpose of having a template in the first place.

@PVince81 PVince81 added this to the backlog milestone Mar 1, 2016
@PVince81 PVince81 mentioned this issue May 19, 2016
Merged
28 tasks
@PVince81 PVince81 mentioned this issue Mar 8, 2017
Merged
@PVince81
Copy link
Contributor Author

might also need something similar for vuejs/pug templates then...

cc @felixheidecke

@DeepDiver1975
Copy link
Member

afaik not - market app is vue.js based and translations strings are extracted from the final generated js code.

@felixheidecke
Copy link
Contributor

indeed no changes needed for vue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp:core-js enhancement status/STALE
Projects
None yet
Milestone
maybe some day
Development

No branches or pull requests
6 participants
@PVince81 @karlitschek @DeepDiver1975 @felixheidecke @AlexAndBear @ownclouders