-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updater warning to prevent skipping major versions #11078
Comments
Just to be clear, this is for the update process in core, the one that shows you the page where you click "Upgrade now". Care needs to be taken as well that the check also blocks CLI updates. |
Refuse. Because it will otherwise trigger bugs as we have seen in the bug tracker |
Completely agree. We know several instances where this is a problem. But, it should tell the admin to upgrade to the next major version first when it refuses to upgrade. |
I think we also needs to add this to the updater app then. @VicDeo pointed out that this requires changes on the server-side. Can you please elaborate again? Thanks. |
@LukasReschke The idea is that the update server only send 7 if 6 is the current version. But this only handles the updater case but not the rpm or tar upgrade. |
Sure. Just wanted to ensure that this gets fixed as well :-) |
@LukasReschke |
Added a version comparison to refuse downgrade/skipping major releases with Updater owncloud/updater#35 |
I played around with that: #11163 |
Upgrading directly from OC 5 to OC 7 is not supported.
To avoid this situation to produce unpredictable result, the update process should have an additional check to make sure that major versions are not skipped.
Whenever it detects that this is the case, it will refuse to update.
@karlitschek refuse or warn ?
CC @MTRichards @craigpg
The text was updated successfully, but these errors were encountered: