Merge pull request #37844 from owncloud/improve-error-handling-getArr…

…ayOfShareesResponded [Tests-Only] Improve error reporting when getArrayOfShareesResponded response has missing data
owncloud · Aug 25, 2020 · d65b8b5 · d65b8b5
2 parents 5804220 + 117b79b
commit d65b8b5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/tests/acceptance/features/bootstrap/ShareesContext.php b/tests/acceptance/features/bootstrap/ShareesContext.php
@@ -148,6 +148,12 @@ public function getArrayOfShareesResponded(
 			$shareeType = \substr($shareeType, 6);
 		}
 
+		Assert::assertArrayHasKey(
+			$shareeType,
+			$elements,
+			__METHOD__ . " The sharees response does not have key '$shareeType'"
+		);
+
 		$sharees = [];
 		foreach ($elements[$shareeType] as $element) {
 			if (\is_int(\key($element))) {

diff --git a/tests/acceptance/features/bootstrap/TrashbinContext.php b/tests/acceptance/features/bootstrap/TrashbinContext.php
@@ -435,7 +435,7 @@ public function asFileOrFolderExistsInTrash($user, $path) {
 
 		Assert::assertNotNull(
 			$firstEntry,
-			"The first trash entry is found null unexpectedly"
+			"The first trash entry was not found while looking for trashbin entry '$path' of user '$user'"
 		);
 
 		if (\count($sections) !== 1) {