Skip to content

Commit

Permalink
Fix grammar in comments
Browse files Browse the repository at this point in the history
  • Loading branch information
VicDeo committed Jun 16, 2020
1 parent 3fd3ac3 commit 1972cd0
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions apps/federatedfilesharing/lib/FederatedShareProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ public function delete(IShare $share) {
$this->revokeShare($share, false);
}

// send revoke notification to the other user, if initiator and owner are not the same user
// send revoke notification to the other user
if ($this->shouldNotifyRemote($share)) {
$remoteId = $this->getRemoteId($share);
if ($isOwner) {
Expand All @@ -553,7 +553,7 @@ public function delete(IShare $share) {
* @throws \OC\HintException
*/
protected function revokeShare($share, $isOwner) {
// also send a unShare request to the initiator, if this is a different user than the owner
// also send a unShare request to the initiator
if ($this->shouldNotifyRemote($share)) {
if ($isOwner) {
list(, $remote) = $this->addressHandler->splitUserRemote($share->getSharedBy());
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -536,8 +536,8 @@ public function testUpdate($owner, $sharedBy, $isOwnerLocal, $isSharerLocal, $sh

public function datatTestUpdate() {
return [
// IRL it is not possible to get both true and false from userManager->userExists on the same uid
// so this cases are skipped
// IRL it is not possible to get both true and false from userManager->userExists for the same uid
// so these cases are skipped
['owner', 'owner', true, true, false], // no update: owner is the same with sharer
['owner', 'sharer', true, true, false], // no update: both owner and sharer are local
['owner@remote', 'sharer', false, true, true], // update: owner differs with sharer and owner is remote
Expand Down

0 comments on commit 1972cd0

Please sign in to comment.