Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Notifications] Ability to control types of enabled desktop notifications #6443

Open
tomneedham opened this issue Apr 10, 2018 · 4 comments
Open

Comments

@tomneedham
Copy link

screen shot 2018-04-10 at 12 01 21

This checkbox decides whether I get native desktop notifications - which is cool. But, in my use case, I really don't want to see every action I perform as a notification on my desktop. If its a received share, and another user changes something, maybe, but actions I perform on my own set of data I dont want to appear as notifications - so basically I have always had this option disabled.

However - getting ownCloud notifications as desktop notifications is awesome, like acept/reject shares, new updates, annoucement etc is AWESOME! I would like to be able to distinguish between them so I can have those enabled, but hide the normal sync activity notifications.

@tomneedham
Copy link
Author

Just my thoughts / ideas :)

@SamuAlfageme SamuAlfageme changed the title [FR] Ability to control types of enabled desktop notifications [Notifications] Ability to control types of enabled desktop notifications Apr 10, 2018
@SamuAlfageme
Copy link
Contributor

@tomneedham Hm. I think I get it. We should distinguish between two types of notifications:

  • Related to server activity -> appear on the "Activity" tab
  • Coming from the sync process itself -> link to "Sync Protocol / Not Synced" tabs with different events:
    • Conflicts
    • Errors

Both types get a native notification. You wanna see the ones from the server and filter out the frequency of the latter (e.g. get conflicts and errors but no notification on sync success - right?).

I really don't want to see every action I perform as a notification on my desktop

How's your user experience with this? Do you have examples of which notifications would you like to see less frequently?

And about the OCS' notifications - API does not differentiate types, they're all inside a data array:

{
    "ocs": {
        "meta": {
            "status": "ok",
            "statuscode": 200,
            "message": null,
            "totalitems": "",
            "itemsperpage": ""
        },
        "data": [
            {
                "notification_id": 1,
                "app": "market",
                "user": "admin",
                "datetime": "2018-04-10T08:11:02+00:00",
                "object_type": "templateeditor",
                "object_id": "0.3",
                "subject": "Update for Mail Template Editor to version 0.3 is available.",
                "message": "",
                "link": "http://localhost/index.php/apps/market/#/app/templateeditor",
                "actions": [],
                "icon": ""
            }
        ]
    }
}

However, we could filter out (whitelist) which apps' notifications to display on the activity tab based on the user selection. e.g. Since marketplace was released, being an admin gets you lots of "update the app X" desktop notifications.

@ckamm
Copy link
Contributor

ckamm commented Apr 11, 2018

I also think this makes sense. It's purely informational can-be-ignored notifications versus action-needed or critical notifications.

@tomneedham
Copy link
Author

@SamuAlfageme correct. There should be two checkboxes, not sure on naming but as you said:

  • Server notifications (those shown in the bell)
  • Sync protocol notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants