Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files to be downloaded with filename with unsupported characters should show error early? #5963

Closed
moscicki opened this issue Aug 15, 2017 · 11 comments

Comments

@moscicki
Copy link
Contributor

There appears to be a regression in 2.2.4 and 2.3.1 #5076

Could you please confirm?

@guruz
Copy link
Contributor

guruz commented Aug 15, 2017

@moscicki Current version is 2.3.3rc1 :-) Re-try that first..

@yolanda93
Copy link

We have tried with the current version (2.3.3rc1) and the problem remains

@michaelstingl
Copy link
Contributor

michaelstingl commented Aug 16, 2017

@moscicki @yolanda93 Could you send the exact "steps to reproduce" to better cover it in qa?

@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented Aug 16, 2017

@michaelstingl no need, I could reproduce by simply including a colon on any filename via webUI and forcing/waiting for sync.

@ogoffart @guruz wonder if the new encoding/decoding logic (#5875) could have some impact here. Probably that is making the error to go unnoticed.

UPDATE: 2.3.2 is also affected. Some bisect support here? cc/ @ckamm as he did some error-refactorings there that could trigger this.

@guruz guruz changed the title regression: files with unsupported characters on Windows silently ignored (2.1) #5076 [Windows] [2.3.3rc1] regression: files to be downloaded with filename with unsupported characters on Windows silently ignored #5076 Aug 24, 2017
@guruz
Copy link
Contributor

guruz commented Aug 24, 2017

I'm creating a file called : on the web interface with oC 9.1.6.2 and sync down in Windows 10.x with 2.3.3rc2

I can then clearly see it in Not Synced tab as File names containing the character ':' are not supported on this file system.

@moscicki @yolanda93 Can you give me more detailed reproduction steps?
Are you sure you waited for the next sync to happen and then checked the Not Synced tab?
It would be good to run the client with log file and paste a link to log file here.

Now the big question is of course how was @SamuAlfageme able to reproduce!?
Is it because you all have different oC versions?
But I thought for downloading those checks are client side..

@SamuAlfageme
Copy link
Contributor

@guruz

But I thought for downloading those checks are client side..

Indeed; you're right, I'm seeing the entries appear on "Not Synced" after a few seconds, I think the other day I assumed not seeing the file-count in the tab meant there was nothing there (I'm used to it on 2.4 by now):

2.3.X 2.4.0
screenshot 2017-08-24 12 35 44 screenshot 2017-08-24 12 59 54

@moscicki @yolanda93 do you guys have any more insights on how to reproduce it?

@guruz
Copy link
Contributor

guruz commented Aug 25, 2017

@moscicki @yolanda93 ping ^^

@yolanda93
Copy link

The same as @guruz, sorry. Now, I double checked waiting a few seconds and it appears in Not Synced tab.

@guruz
Copy link
Contributor

guruz commented Aug 25, 2017

@yolanda93 great!

@ogoffart @mrow4a Just a thought we could have those kind of error jobs (generated by a sync job, not in discovery) be ordered very early so that they are visible earlier in the UI?
I don't know how this is influenced by renames/moves

@guruz guruz changed the title [Windows] [2.3.3rc1] regression: files to be downloaded with filename with unsupported characters on Windows silently ignored #5076 files to be downloaded with filename with unsupported characters should show error early? Aug 25, 2017
@guruz guruz removed the p2-high label Aug 25, 2017
@mrow4a
Copy link
Contributor

mrow4a commented Aug 26, 2017

Hmm, I think we can do that, any priority for that?

@ogoffart
Copy link
Contributor

ogoffart commented Dec 4, 2018

Recent version reads the invalidFilenameRegex from the capabilities.

@ogoffart ogoffart closed this as completed Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants