Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OS X] Improve macdeployqt.py #5447

Closed
SamuAlfageme opened this issue Jan 12, 2017 · 4 comments
Closed

[OS X] Improve macdeployqt.py #5447

SamuAlfageme opened this issue Jan 12, 2017 · 4 comments
Labels
macOS packaging technical debt type:bug

Comments

@SamuAlfageme
Copy link
Contributor

SamuAlfageme commented Jan 12, 2017 •
edited
Loading

Yesterday, while trying some custom builds with old changes over the CI, using qt5.6.2 instead of qt5.4.0 made this happen:

... 
+ ../admin/osx/gen_sym_files.py /Users/builder/dump_syms /Users/builder/workspace/ownCloud-client-osx/install/alfageme.app /Users/builder/workspace/ownCloud-client-osx/install/symbols
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtSql.framework/Versions/5/QtSql]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtWebKitWidgets.framework/Versions/5/QtWebKitWidgets]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtWebKit.framework/Versions/5/QtWebKit]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtXml.framework/Versions/5/QtXml]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtWidgets.framework/Versions/5/QtWidgets]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtNetwork.framework/Versions/5/QtNetwork]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtMacExtras.framework/Versions/5/QtMacExtras]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtGui.framework/Versions/5/QtGui]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtConcurrent.framework/Versions/5/QtConcurrent]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/Sparkle.framework/Versions/A/Sparkle]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtCore.framework/Versions/5/QtCore]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtMacExtras.framework/Versions/5/QtMacExtras]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtWidgets.framework/Versions/5/QtWidgets]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtNetwork.framework/Versions/5/QtNetwork]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtGui.framework/Versions/5/QtGui]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtCore.framework/Versions/5/QtCore]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtSql.framework/Versions/5/QtSql]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtNetwork.framework/Versions/5/QtNetwork]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtWidgets.framework/Versions/5/QtWidgets]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtConcurrent.framework/Versions/5/QtConcurrent]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtMacExtras.framework/Versions/5/QtMacExtras]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtGui.framework/Versions/5/QtGui]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtCore.framework/Versions/5/QtCore]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/Sparkle.framework/Versions/A/Sparkle]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtWidgets.framework/Versions/5/QtWidgets]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtNetwork.framework/Versions/5/QtNetwork]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtConcurrent.framework/Versions/5/QtConcurrent]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtMacExtras.framework/Versions/5/QtMacExtras]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/Sparkle.framework/Versions/A/Sparkle]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtGui.framework/Versions/5/QtGui]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/QtCore.framework/Versions/5/QtCore]
WARNING:root:Non-existant file found in dependencies, ignoring: [/Users/builder/workspace/ownCloud-client-osx/install/alfageme.app/Contents/MacOS/FinderSync.framework/Versions/A/FinderSync]
...

So most of Qt libraries weren't included on a small and broken .pkg while the build was marked as successful on Jenkins. These kind of problems should be considered errors, not warnings, and therefore make the deploy script and CI job fail.

I know this had to do with the changes in the dependencies that doesn't happen that often, but better safe than sorry.
@guruz guruz changed the title [OS X] Improve/replace macdeployqt.py with a better deployment script [OS X] Improvemacdeployqt.py with a better deployment script Jan 13, 2017
@guruz
Copy link
Contributor

guruz commented Jan 13, 2017

Can you find out what the exact cause is?
Did it return a non-0?
Did it return a non-0 but Jenkins did not see this as failing?

@guruz guruz changed the title [OS X] Improvemacdeployqt.py with a better deployment script [OS X] Improve macdeployqt.py Jan 13, 2017
@SamuAlfageme
Copy link
Contributor Author

@guruz Here's the full console log from the CI.

My gut says it returned a 0 since those were considered warnings, then generated a .pkg and everything was just fine for Jenkins.

You can replicate by switching the branch to #5340 and the Qt version to qt5.6.2. I'll try to dig on the return codes and the state of the machine.

@jturcotte
Copy link
Member

jturcotte commented Apr 7, 2017 •
edited
Loading

We should just use the official macdeployqt if the one we have is incomplete/buggy. Back at the beginning it was still unreliable and I think that's why we rolled out our own.

I almost did it for the 5.6 update but I managed to fix the script easily so it wasn't worth it.

@SamuAlfageme SamuAlfageme mentioned this issue Nov 13, 2017
Closed
@TheOneRing
Copy link
Contributor

No longer used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
macOS packaging technical debt type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TheOneRing @jturcotte @guruz @SamuAlfageme