Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict Files: Consider to add a Notification about them #4813

Closed
dragotin opened this issue May 9, 2016 · 8 comments
Closed

Conflict Files: Consider to add a Notification about them #4813

dragotin opened this issue May 9, 2016 · 8 comments
Assignees
Milestone

Comments

@dragotin
Copy link
Contributor

dragotin commented May 9, 2016

Expected behaviour

If there is a conflict file, the user should be informed about. That happens through a toast message and an entry in the Not synced list. #3222

However, with the next sync run, the Not synced list is wiped, so that the conflict entries are lost. The next sync can happen quite soon after the conflict happened.

Maybe the conflicts should become notifications which only go away after the user clicked on "Close", similar to the notifications that we get from the server if a remote share happens.

Alternatively we could add code which lets the conflict entry not go away for a certain time span.

Actual behaviour

Currently, if a conflict happens, a tray notification pops up and in the Not synced list appears an entry. The problem is that this one can disappear quickly.

Steps to reproduce

  1. create a conflict file
  2. check that the conflict entry is in the not synced list
  3. See how it vanishes from there with the next sync.
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/34047945-conflict-files-consider-to-add-a-notification-about-them?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github).
@dragotin dragotin self-assigned this May 9, 2016
@guruz guruz added this to the 2.2.1-current milestone May 18, 2016
@guruz
Copy link
Contributor

guruz commented May 18, 2016

Also check #4079

@guruz
Copy link
Contributor

guruz commented May 18, 2016

Isn't this done already?
52a5234

@mcastroSG ?

@guruz
Copy link
Contributor

guruz commented May 18, 2016

Actually @dragotin wants more persistent notifications: #4697

@mcastroSG
Copy link

@guruz Conflict file alerts have not been included as notifications in the same way than Announcements or remote federated sharing files but it will be 😄

@dragotin dragotin modified the milestones: 2.4.0, 2.3.0 May 20, 2016
@ckamm
Copy link
Contributor

ckamm commented Jul 13, 2017

We now have a persistent list of conflicts in the issues tab. I think that's mostly equivalent to showing them in the notifications view - @dragotin agreed?

@guruz
Copy link
Contributor

guruz commented Jul 13, 2017

@ckamm Maybe you mean a different thing by 'notifications'? We mean https://support.apple.com/en-us/HT204079

@ckamm
Copy link
Contributor

ckamm commented Jul 13, 2017

@guruz Oh. I thought server notifications that are displayed in the "Server activity" tab were meant. We don't have these fancy notifications anywhere yet, do we?

EDIT: Chatting with @guruz: We do have a non-interactive non-sticky tray message for conflicts ("a.txt and three other files had conflicts") already, but nothing sticky-interactive like the OSX alerts.

@guruz
Copy link
Contributor

guruz commented Jul 13, 2017

OK..
then this is partly solved by your issues tab and partly handled by #4697

Closing

@guruz guruz closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants