Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide tests for propagator jobs #2540

Closed
dragotin opened this issue Nov 25, 2014 · 6 comments
Closed

Provide tests for propagator jobs #2540

dragotin opened this issue Nov 25, 2014 · 6 comments
Assignees

Comments

@dragotin
Copy link
Contributor

We need automatted tests for the QNAM based propagator jobs that can run through Jenkins. We also should test error conditions. Ideally the test would spit out a list of http error codes and their resulting reaction of the job, for example:

Error Code Reaction Error Message
200 Ok -
402 Soft error Directory could not be created
500 Hard error Internal server error

That might require to have a special testing app for the ownCloud server. Also that might require a bit of C++ class redesign to make it better testable.

@dragotin dragotin added this to the 1.8 - UI Enhancements milestone Nov 25, 2014
@dragotin dragotin added the p2-high Escalation, on top of current planning, release blocker label Nov 25, 2014
@dragotin dragotin added Discussion and removed p2-high Escalation, on top of current planning, release blocker labels Jan 19, 2015
@dragotin
Copy link
Contributor Author

This needs more discussion. We can not easily provide tests for the job classes, we need a server etc etc. We need to see how that than is different from tx.pl or smashbox.

@moscicki
Copy link
Contributor

Yep. Ideally we would also like to do some fault injection like timeouts, connections interrupted, packets lost, etc.

@nickvergessen
Copy link
Contributor

@orion1024 because you commented in owncloud/core#24684

Tests exist today but they are not automated (perl, smashbox), not comprehensive (linux-only support, no error-handling tests, no multiple clients/servers combo tests) and some are not available (smashbox) for an external contributor.

Just want to make sure:

  1. Smashbox tests run on each daily and they are automated: https://ci.owncloud.org/view/smashbox/
  2. They are available for "external contributor" since the repo is public: https://github.com/owncloud/smashbox

If you need further assistance on getting them running, feel free to poke

@orion1024
Copy link
Contributor

orion1024 commented May 23, 2016

@nickvergessen I wasn't aware of all that, thanks.
I read on the wiki that they were run manually for the client so I didn't dig deep enough.
From I saw Docker is used. Is it mandatory ? because it's neither free nor cheap.

edit : doesn't seems so, from the README on github repo. I will study this further, thanks for the tip.

@ogoffart
Copy link
Contributor

@nickvergessen AFAIK, the smashbox tests are not running for development versions of the client.

@ogoffart
Copy link
Contributor

There is now a sync engine test framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants