Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated tests for quota checks #461

Closed
PVince81 opened this issue Jun 19, 2017 · 5 comments · Fixed by owncloud/core#28160
Closed

Automated tests for quota checks #461

PVince81 opened this issue Jun 19, 2017 · 5 comments · Fixed by owncloud/core#28160
Assignees

Comments

@PVince81
Copy link
Contributor

PVince81 commented Jun 19, 2017

Matrix dimensions:

  • dimension 1:
    • "enough quota"
    • "not enough quota"
  • dimension 2:
    • "old dav endpoint"
    • "new dav endpoint"
  • dimension 3: upload type:
    • "regular upload"
    • "chunked upload" (if old dav, use "OC-Chunked" approach, if new dav, use the "uploads" endpoint)
    • "OC-Chunked code" for new dav endpoint
  • dimension 4: upload target:
    • "regular folder"
    • "received shared folder"
    • "overwrite file inside received shared folder"
    • "overwrite received shared file (direct file share, in this case the quota check must happen on the file's storage, special case!)
  • dimension 5: whether new file or overwriting

@owncloud/qa

@PVince81
Copy link
Contributor Author

I thought of these cases while looking into a potential fix for owncloud/core#28159 which will likely affect all of the cases above...

@PVince81
Copy link
Contributor Author

some ideas to make implementation for this easier:

  • have a scenario step "for all upload types" that does 3 uploads of the same file using the 3 ways

@PVince81
Copy link
Contributor Author

Let's add a new upload step: `When User "$user" uploads file "$file" to "$target" with any dav and any upload type".

This would then run the matrix between "new dav, old dav" and "non-chunked and chunked" dimensions.

Everything else to be implemented in separate scenarios.

@PVince81
Copy link
Contributor Author

Tests hypercube implemented here: owncloud/core#28160.

@PVince81
Copy link
Contributor Author

added new dimension "new file vs overwriting" which also triggers different code paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant