From c5e6368b06ec4d3cec0768d01517d38ca5bc3986 Mon Sep 17 00:00:00 2001 From: Brian Austin <13002992+brianjaustin@users.noreply.github.com> Date: Wed, 20 Mar 2024 01:10:49 -0400 Subject: [PATCH 01/14] AO3-6596 Update first login help test to reflect stage/prod (#4768) * AO3-6596 Update first help test to reflect stage/prod * Clearer step --- features/other_a/help.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/features/other_a/help.feature b/features/other_a/help.feature index 4563f6ae07d..da05dc690bc 100644 --- a/features/other_a/help.feature +++ b/features/other_a/help.feature @@ -35,7 +35,7 @@ Feature: Help Scenario: Asked to log in if trying to access the first login page as guest When I go to the first login help page - Then I should see "Sorry, you don't have permission" + Then I should be on the login page Given I am logged in When I go to the first login help page From 4fecf782bcc40599f008ab53478edb70501febd8 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 20 Mar 2024 16:43:18 -0700 Subject: [PATCH 02/14] AO3-6695 Bump reviewdog/action-rubocop from 2.8.0 to 2.9.0 (#4766) Bump reviewdog/action-rubocop from 2.8.0 to 2.9.0 Bumps [reviewdog/action-rubocop](https://github.com/reviewdog/action-rubocop) from 2.8.0 to 2.9.0. - [Release notes](https://github.com/reviewdog/action-rubocop/releases) - [Commits](https://github.com/reviewdog/action-rubocop/compare/2f726ae5dd8df72b4faa9d93669cdab96aeb2153...2c8048e3169487eccc1eed812daaa6e5275a809f) --- updated-dependencies: - dependency-name: reviewdog/action-rubocop dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- .github/workflows/reviewdog.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 58d50002cce..ac3a43edff9 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -21,7 +21,7 @@ jobs: bundler-cache: true - name: rubocop - uses: reviewdog/action-rubocop@2f726ae5dd8df72b4faa9d93669cdab96aeb2153 + uses: reviewdog/action-rubocop@2c8048e3169487eccc1eed812daaa6e5275a809f with: use_bundler: true reporter: github-pr-check From 79206d703694da6d82846743a8fdafd1683b9dcb Mon Sep 17 00:00:00 2001 From: Bilka Date: Thu, 21 Mar 2024 00:43:29 +0100 Subject: [PATCH 03/14] AO3-6696 Change reviewdog workflows to install only linter gems (#4767) Change reviewdog workflows to install only linter gems --- .github/workflows/reviewdog.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index ac3a43edff9..3af37b18225 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -11,6 +11,8 @@ jobs: rubocop: name: Rubocop runs-on: ubuntu-latest + env: + BUNDLE_ONLY: linters steps: - name: Check out code uses: actions/checkout@v4 @@ -30,6 +32,8 @@ jobs: erb-lint: name: ERB Lint runner runs-on: ubuntu-latest + env: + BUNDLE_ONLY: linters steps: - name: Check out code uses: actions/checkout@v4 From 95384815c5ec10a706a155f2990ca9a86494108c Mon Sep 17 00:00:00 2001 From: sarken Date: Sun, 24 Mar 2024 15:52:40 -0400 Subject: [PATCH 04/14] AO3-6689 Improve accessibility of header and navigation (#4754) * AO3-6689 Use correct roles in header navigation - Use nav element to convey role=navigation - Use aria-label in place of landmark headings - Use search element to convey role=search for search - Remove role=menu where it occurs and update JavaScript accordingly - Stop adding role=menuitem now that we no longer use role=menu - Use header element for header instead of div * AO3-6689 Header i18n * AO3-6689 Fix indentation * AO3-6689 Fix line numbers in code comment * AO3-6689 Prefer search role to search element due to browser support Refer to https://caniuse.com/mdn-html_elements_search * AO3-6689 Update static pages * AO3-6689 Code style fixes * AO3-6689 Fix minified JavaScript * AO3-6689 Hey another code style fix * AO3-6689 Fix tests that mistakenly passing * AO3-6689 One-line logic for collection h2 text Co-authored-by: Brian Austin <13002992+brianjaustin@users.noreply.github.com> --------- Co-authored-by: Brian Austin <13002992+brianjaustin@users.noreply.github.com> --- app/views/admin/_header.html.erb | 125 ++++++++--------- app/views/layouts/_header.html.erb | 71 +++++----- app/views/menu/_menu_about.html.erb | 12 +- app/views/menu/_menu_browse.html.erb | 10 +- app/views/menu/_menu_fandoms.html.erb | 4 +- app/views/menu/_menu_search.html.erb | 10 +- app/views/users/sessions/_greeting.html.erb | 55 ++++---- app/views/works/_search_box.html.erb | 11 +- config/locales/views/en.yml | 85 ++++++++++++ features/other_b/skin.feature | 3 +- public/403.html | 126 ++++++++--------- public/445.html | 127 ++++++++--------- public/500.html | 127 ++++++++--------- public/502.html | 127 ++++++++--------- public/503.html | 126 ++++++++--------- public/507.html | 126 ++++++++--------- public/javascripts/application.js | 1 - .../bootstrap/bootstrap-dropdown.js | 15 +- .../bootstrap/bootstrap-dropdown.min.js | 2 +- public/nomaintenance.html | 127 ++++++++--------- public/status/index.html | 130 +++++++++--------- 21 files changed, 749 insertions(+), 671 deletions(-) diff --git a/app/views/admin/_header.html.erb b/app/views/admin/_header.html.erb index 0f319e124dc..e2e16dca705 100644 --- a/app/views/admin/_header.html.erb +++ b/app/views/admin/_header.html.erb @@ -1,72 +1,73 @@ -

<%= ts("Admin Navigation", key: "header") %>

-