From 927b2034dbb1c3385910c46187e0f0c2bc762539 Mon Sep 17 00:00:00 2001
From: salt <60383410+saltlas@users.noreply.github.com>
Date: Sun, 3 Dec 2023 17:22:18 +1300
Subject: [PATCH] AO3-5386 Remove edit_emails_off and plain_text_skin columns
 from preferences table (#4540)

* add migration to remove columns from preferences and remove mentions of those columns from preferences.yml

* hound
---
 ...ls_and_plain_text_skin_from_preferences.rb | 53 +++++++++++++++
 test/fixtures/preferences.yml                 | 64 -------------------
 2 files changed, 53 insertions(+), 64 deletions(-)
 create mode 100644 db/migrate/20230418071728_remove_edit_emails_and_plain_text_skin_from_preferences.rb

diff --git a/db/migrate/20230418071728_remove_edit_emails_and_plain_text_skin_from_preferences.rb b/db/migrate/20230418071728_remove_edit_emails_and_plain_text_skin_from_preferences.rb
new file mode 100644
index 00000000000..ac39e5adc91
--- /dev/null
+++ b/db/migrate/20230418071728_remove_edit_emails_and_plain_text_skin_from_preferences.rb
@@ -0,0 +1,53 @@
+class RemoveEditEmailsAndPlainTextSkinFromPreferences < ActiveRecord::Migration[6.1]
+  def up
+    if Rails.env.staging? || Rails.env.production?
+      database = Preference.connection.current_database
+
+      puts <<~PTOSC
+        Schema Change Command:
+
+        pt-online-schema-change D=#{database},t=preferences \\
+          --alter "DROP COLUMN edit_emails_off,
+                   DROP COLUMN plain_text_skin" \\
+          --no-drop-old-table \\
+          -uroot --ask-pass --chunk-size=5k --max-flow-ctl 0 --pause-file /tmp/pauseme \\
+          --max-load Threads_running=15 --critical-load Threads_running=100 \\
+          --set-vars innodb_lock_wait_timeout=2 --alter-foreign-keys-method=auto \\
+          --execute
+
+        Table Deletion Command:
+
+        DROP TABLE IF EXISTS `#{database}`.`_preferences_old`;
+      PTOSC
+    else
+      remove_column :preferences, :edit_emails_off
+      remove_column :preferences, :plain_text_skin
+    end
+  end
+
+  def down
+    if Rails.env.staging? || Rails.env.production?
+      database = Preference.connection.current_database
+
+      puts <<~PTOSC
+        Schema Change Command:
+
+        pt-online-schema-change D=#{database},t=preferences \\
+          --alter "ADD COLUMN edit_emails_off BOOLEAN NOT NULL DEFAULT 0,
+                   ADD COLUMN plain_text_skin BOOLEAN NOT NULL DEFAULT 0" \\
+          --no-drop-old-table \\
+          -uroot --ask-pass --chunk-size=5k --max-flow-ctl 0 --pause-file /tmp/pauseme \\
+          --max-load Threads_running=15 --critical-load Threads_running=100 \\
+          --set-vars innodb_lock_wait_timeout=2 --alter-foreign-keys-method=auto \\
+          --execute
+
+        Table Deletion Command:
+
+        DROP TABLE IF EXISTS `#{database}`.`_preferences_old`;
+      PTOSC
+    else
+      add_column :preferences, :edit_emails_off, :boolean, default: false, null: false
+      add_column :preferences, :plain_text_skin, :boolean, default: false, null: false
+    end
+  end
+end
diff --git a/test/fixtures/preferences.yml b/test/fixtures/preferences.yml
index 526cf50341e..780fd3f36a2 100644
--- a/test/fixtures/preferences.yml
+++ b/test/fixtures/preferences.yml
@@ -12,7 +12,6 @@ preference_484751134:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 22:39:55 Z
-  plain_text_skin: false
   first_login: false
   email_visible: false
   adult: false
@@ -21,7 +20,6 @@ preference_484751134:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -38,7 +36,6 @@ preference_484751112:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-06 22:58:44 Z
-  plain_text_skin: true
   first_login: true
   email_visible: false
   adult: false
@@ -47,7 +44,6 @@ preference_484751112:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -64,7 +60,6 @@ preference_484751123:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:07:00 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -73,7 +68,6 @@ preference_484751123:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -90,7 +84,6 @@ preference_484751124:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:07:09 Z
-  plain_text_skin: true
   first_login: true
   email_visible: false
   adult: false
@@ -99,7 +92,6 @@ preference_484751124:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -116,7 +108,6 @@ preference_484751113:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-06 23:03:31 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -125,7 +116,6 @@ preference_484751113:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -142,7 +132,6 @@ preference_484751135:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 23:46:16 Z
-  plain_text_skin: false
   first_login: false
   email_visible: false
   adult: false
@@ -151,7 +140,6 @@ preference_484751135:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -168,7 +156,6 @@ preference_484751136:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-17 11:37:58 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -177,7 +164,6 @@ preference_484751136:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -194,7 +180,6 @@ preference_484751114:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-06 23:05:24 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -203,7 +188,6 @@ preference_484751114:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -220,7 +204,6 @@ preference_484751125:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:07:24 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -229,7 +212,6 @@ preference_484751125:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -246,7 +228,6 @@ preference_484751126:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:08:22 Z
-  plain_text_skin: false
   first_login: false
   email_visible: false
   adult: false
@@ -255,7 +236,6 @@ preference_484751126:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -272,7 +252,6 @@ preference_484751115:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-06 23:13:19 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -281,7 +260,6 @@ preference_484751115:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -298,7 +276,6 @@ preference_78869998:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-11-09 01:26:01 Z
-  plain_text_skin: false
   first_login: true
   email_visible: true
   adult: false
@@ -307,7 +284,6 @@ preference_78869998:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -324,7 +300,6 @@ preference_484751116:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-06 23:29:42 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -333,7 +308,6 @@ preference_484751116:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -350,7 +324,6 @@ preference_484751127:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:07:42 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -359,7 +332,6 @@ preference_484751127:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -376,7 +348,6 @@ preference_484751128:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:07:52 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -385,7 +356,6 @@ preference_484751128:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -402,7 +372,6 @@ preference_484751117:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: true
   updated_at: 2008-12-07 19:54:32 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -411,7 +380,6 @@ preference_484751117:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -428,7 +396,6 @@ preference_78869999:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: true
   updated_at: 2009-03-14 22:16:33 Z
-  plain_text_skin: false
   first_login: true
   email_visible: true
   adult: true
@@ -437,7 +404,6 @@ preference_78869999:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -454,7 +420,6 @@ preference_484751107:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-22 11:27:28 Z
-  plain_text_skin: false
   first_login: false
   email_visible: true
   adult: true
@@ -463,7 +428,6 @@ preference_484751107:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: true
   disable_work_skins: false
@@ -480,7 +444,6 @@ preference_78870000:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-11-09 01:26:01 Z
-  plain_text_skin: false
   first_login: true
   email_visible: true
   adult: false
@@ -489,7 +452,6 @@ preference_78870000:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -506,7 +468,6 @@ preference_484751118:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-07-18 10:22:34 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: true
@@ -515,7 +476,6 @@ preference_484751118:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -532,7 +492,6 @@ preference_484751129:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:08:12 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -541,7 +500,6 @@ preference_484751129:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -558,7 +516,6 @@ preference_484751130:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:09:13 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -567,7 +524,6 @@ preference_484751130:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -584,7 +540,6 @@ preference_484751119:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-07-17 23:18:52 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -593,7 +548,6 @@ preference_484751119:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -610,7 +564,6 @@ preference_484751108:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-05 13:55:28 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -619,7 +572,6 @@ preference_484751108:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -636,7 +588,6 @@ preference_484751109:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-05 13:55:29 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -645,7 +596,6 @@ preference_484751109:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -662,7 +612,6 @@ preference_484751120:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-07-18 09:55:25 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -671,7 +620,6 @@ preference_484751120:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -688,7 +636,6 @@ preference_484751131:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:10:24 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -697,7 +644,6 @@ preference_484751131:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -714,7 +660,6 @@ preference_484751132:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:13:55 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -723,7 +668,6 @@ preference_484751132:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -740,7 +684,6 @@ preference_484751110:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-05 14:07:24 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -749,7 +692,6 @@ preference_484751110:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -766,7 +708,6 @@ preference_484751122:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-09-16 23:37:53 Z
-  plain_text_skin: true
   first_login: true
   email_visible: false
   adult: false
@@ -775,7 +716,6 @@ preference_484751122:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -792,7 +732,6 @@ preference_484751111:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2008-12-06 22:53:08 Z
-  plain_text_skin: false
   first_login: true
   email_visible: false
   adult: false
@@ -801,7 +740,6 @@ preference_484751111:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false
@@ -818,7 +756,6 @@ preference_484751133:
   work_title_format: TITLE - AUTHOR - FANDOM
   view_full_works: false
   updated_at: 2009-12-12 21:58:30 Z
-  plain_text_skin: false
   first_login: false
   email_visible: false
   adult: false
@@ -827,7 +764,6 @@ preference_484751133:
   recipient_emails_off: false
   date_of_birth_visible: false
   time_zone: 
-  edit_emails_off: false
   minimize_search_engines: false
   hide_warnings: false
   disable_work_skins: false