This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
Fix deploy error #384
Merged
Fix deploy error #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was debugging an error and was trying to figure out which of these it was coming from (the answer was neither though).
I was trying to use coreos/coreos-assembler#2523 to test something and discovered that coreos/coreos-assembler#2523 regressed this. We need to use the target imgref if provided.
lucab
approved these changes
Oct 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/container: Add context to prepare/import
I was debugging an error and was trying to figure out which
of these it was coming from (the answer was neither though).
cli: Fix error when using deploy --target-imgref
I was trying to use coreos/coreos-assembler#2523
to test something and discovered that
coreos/coreos-assembler#2523
regressed this. We need to use the target imgref if provided.