This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
container/deploy: Add a --target-imgref option
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want the ability to separate the image that's pulled from its target reference. This is what we do today in coreos-assembler for pure ostree refs - e.g. we deploy via a commit hash, but still have `ostree admin upgrade` pull from a ref. This is equivalent functionality for containers.
lucab
approved these changes
Oct 29, 2021
| /// If specified, `--imgref` will be used as a source, but this reference will be emitted into the origin | ||
| /// so that later OS updates pull from it. | ||
| #[structopt(long)] | ||
| target_imgref: Option<String>, |
There was a problem hiding this comment.
I guess longer term we'd need to find a better term for this, because I think many people will fall in this pinned-digest vs moveable-tag trap (and I'm still sad we can't use the digest-and-tag form).
There was a problem hiding this comment.
At least in coreos-assembler right now, we're pulling via oci-archive over 9p from the build directory, so the image references look completely different.
But other workflows indeed may want to push to a registry, in which case having a separate --digest argument would make sense.
|
Followup #144 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want the ability to separate the image that's pulled from its
target reference. This is what we do today in coreos-assembler
for pure ostree refs - e.g. we deploy via a commit hash, but
still have
ostree admin upgradepull from a ref.This is equivalent functionality for containers.