Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences from other Gelf encoders #41

Closed
andrebrait opened this issue Nov 28, 2019 · 7 comments · Fixed by #42
Closed

Differences from other Gelf encoders #41

andrebrait opened this issue Nov 28, 2019 · 7 comments · Fixed by #42

Comments

@andrebrait
Copy link
Contributor

It seems the layout used here differs a bit from other popular solutions for other logging frameworks, such as Log4J2's own Gelf encoder).

The two main differences is that Log4J2's sends thread instead of thread_name and logger instead of logger_name.

Unfortunately, this makes filtering logs by such fields a bit of a hassle when there are different systems with different logging frameworks sending logs to the same logstash server.

Would you mind changing this? (I can send the PR, I just need the green light 😄)

@andrebrait
Copy link
Contributor Author

It could also be made a configuration to change the names of those properties, if you think that's better :)

@osiegmar
Copy link
Owner

As there is no standard for the field names of logger_name and thread_name, I've seen many different variations in the wild. I don't want to change the current names as they are not better or worse than any other (and break the compatibility).
But making these configurable is probably a very good idea for those having to manage different applications and their logs. Green light for a PR ;-)

@andrebrait
Copy link
Contributor Author

@osiegmar Done 😉

@osiegmar
Copy link
Owner

osiegmar commented Dec 1, 2019

Thanks!

@andrebrait
Copy link
Contributor Author

Np :-)

I'll watch for releases here so I can update the services that use it when thus gets included in a release

@osiegmar
Copy link
Owner

Just released.

@andrebrait
Copy link
Contributor Author

@osiegmar thanks a lot. It's already working nicely here :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants