Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support changes in /etc/os-release without requiring new OS definitions #816

Open
p5 opened this issue Feb 2, 2025 · 3 comments
Open

Support changes in /etc/os-release without requiring new OS definitions #816

p5 opened this issue Feb 2, 2025 · 3 comments

Comments

@p5
Copy link

p5 commented Feb 2, 2025

Do we want to add manifests for all custom images? I can imageing the list becoming very long. Or should there be some way to pass it in to the build?

Probably a bit of both; I see no real necessity to add these definitions if they're going to be symlinks to centos-9 so perhaps something nice would be possible there so these types of PRs are necessary only for actual new distros.

#771 (comment)

When an image changes the /etc/os-release file, they are no longer able to use bootc-image-builder since they don't have a definition inside the osbuild/bootc-image-builder repo.

As suggested by @supakeen, it would be great to somehow allow the user to say "I am building an image based on C10s" so they don't need to fork or commit these symlinks to this repo.
If they are in fact creating a whole new distro, then it seems okay to require a PR here to centralise things. It should be far less frequent.

@hanthor
Copy link

hanthor commented Feb 2, 2025

https://gitlab.com/fedora/bootc/base-images/-/blob/main/fedora-bootc-config.json?ref_type=heads

Not sure why we are specifying the bib image in the base image but cannot specify the base image in bib?

@ondrejbudai
Copy link
Member

Would something like --iso-def centos-10 help?

Alternatively, you can build a layer on top of bootc-image-builder with your custom defs, but I guess that having "native support" would be better.

@cgwalters
Copy link
Contributor

I think the correct thing to do here is to honor ID_LIKE in the os-release file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants