Unhandled EWOULDBLOCK errors breaking TlsStream

[osa1]

Originally reported by @reading123 on #61,

It seems like some EWOULDBLOCK errors are slipping through our error handlers and causing Conn methods to fail. The error message tiny prints is:

Connection error: The underlying stream reported an error (operation would block)

I can't reproduce this so I'm not sure how to solve. As a starting point we should probably compare our EWOULDBLOCK handling with tokio-core's TcpStream https://github.com/tokio-rs/tokio-core/blob/master/src/net/tcp.rs .

I also created the issue sfackler/rust-native-tls#63 but later it occured to me that if we do EWOULDBLOCK in stream::tcp::TcpStream we may not need any support from native_tls.

[osa1]

I can reproduce this reliably (as in, it never works) when I compile tiny with statically linked openssl-1.1.0g.

[osa1]

@reading123 could you try again with latest tiny? (cargo install --force --git https://github.com/osa1/tiny) If you're getting The OpenSSL library reported an error that's a certificate verification error, I'm not sure how to solve it yet. For some reason it works when I use OpenSSL from my distro's package manager.

[reading123]

Yay it works!! No errors here.

[reading123]

Also, Merry Christmas! :)

[osa1]

Good to hear. Merry Christmas to you too :)