Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot upgrade to latest version #198

Closed
mitar opened this issue Sep 15, 2020 · 3 comments
Closed

Cannot upgrade to latest version #198

mitar opened this issue Sep 15, 2020 · 3 comments

Comments

@mitar
Copy link

mitar commented Sep 15, 2020

Describe the bug

I am trying to upgrade all fosite dependencies using go get -u but it fails

To Reproduce

go get -u ./...

Expected behavior

Dependencies get upgraded.

Expected behavior

I get the following error:

/home/mitar/go/pkg/mod/github.com/ory/x@v0.0.149/logrusx/helper.go:13:2: module go.opentelemetry.io/otel@latest found (v0.11.0), but does not contain package go.opentelemetry.io/otel/plugin/httptrace

It seems go.opentelemetry.io/otel v0.5.0 was the latest version to contain that plugin.

@zepatrik
Copy link
Member

They moved it in open-telemetry/opentelemetry-go#1032 (released with v0.11.0)
But we use v0.6.0 in go.mod anyway, I think you should not upgrade the dependency like this. Maybe just bump the version of ory/x explicitly?

@aeneasr
Copy link
Member

aeneasr commented Sep 16, 2020

go get -u is known to always cause issues because it forcefully updates all dependencies, defeating the purpose of go modules.

@aeneasr aeneasr closed this as completed Sep 16, 2020
@mitar
Copy link
Author

mitar commented Sep 16, 2020

Hm, I will have to learn how to upgrade dependencies better it seems. I was only trying to upgrade fosite and it seems it didn't respect its go.mod. Probably because of the bad command. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants