Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1rc5 BUG - I was able to rename an edge class "something UNSAFE"! #4553

Closed
zifnab87 opened this issue Jul 12, 2015 · 4 comments
Closed

2.1rc5 BUG - I was able to rename an edge class "something UNSAFE"! #4553

zifnab87 opened this issue Jul 12, 2015 · 4 comments
Assignees
Milestone

Comments

@zifnab87
Copy link

I was trying to rename an edge class from one name to a new one. It was telling me to use UNSAFE since this could break Verticies.. Even though I don't understand why this would be a problem.. So I did the same query with UNSAFE at the end ALTER CLASS UNSAFE and it allowed me - I thought it worked but it added UNSAFE in the name of the class :/

I start wondering if I can trust this product ...
image

ALTER CLASS <class> <attribute-name> <attribute-value> UNSAFE

Now I cannot rename it because class has an unexpected attribute UNSAFE :/
com.orientechnologies.orient.core.sql.OCommandSQLParsingException: Error on parsing command at position # 26: Unknown class's attribute 'UNSAFE'. Supported attributes are: [NAME, SHORTNAME, SUPERCLASS, SUPERCLASSES, OVERSIZE, STRICTMODE, ADDCLUSTER, REMOVECLUSTER, CUSTOM, ABSTRACT, CLUSTERSELECTION] Command: alter class ContainsEntity UNSAFE name ContainsEntity ----------------------------------^

@lvca
Copy link
Member

lvca commented Jul 12, 2015

Did you put UNSAFE in " or ' ?

@lvca lvca self-assigned this Jul 12, 2015
@zifnab87
Copy link
Author

The command was ALTER CLASS OldName NAME ContainsEntity UNSAFE
according to ALTER CLASS <class> <attribute-name> <attribute-value> UNSAFE that I think I found somewhere. So I didn't use any quotes. It could just be that there is no check about spaces in names for classes.

@luigidellaquila
Copy link
Member

Hi @zifnab87
I need your help here, I'm trying to reproduce this problem from Studio, but it seems I can't.
Could you please add some details?

@luigidellaquila
Copy link
Member

Ah, ok, I found out why. It was a regression, was fixed six days ago, see commit 26f0f55
There is also a test case on this.

Thanks

@luigidellaquila luigidellaquila added this to the 2.1 GA milestone Jul 13, 2015
@lvca lvca modified the milestones: 2.1 GA, 2.1-rc6 Jul 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants