Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows unit test cannot be compiled #1540

Closed
1 task done
qweeah opened this issue Nov 25, 2024 · 0 comments · Fixed by #1541
Closed
1 task done

Windows unit test cannot be compiled #1540

qweeah opened this issue Nov 25, 2024 · 0 comments · Fixed by #1541
Labels
bug Something isn't working triage New issues or PRs to be acknowledged by maintainers
Milestone

Comments

@qweeah
Copy link
Contributor

qweeah commented Nov 25, 2024

What happened in your environment?

When compiling windows golang unit tests, got bellow error

> go test -count=1 ./...
# oras.land/oras/internal/testutils
internal\testutils\console.go:34:37: undefined: containerd.NewPty

What did you expect to happen?

The unit test should be compiled and run successfully

How can we reproduce it?

Run go test -count=1 ./... on Windows

What is the version of your ORAS CLI?

Dev branch on 5280c67

What is your OS environment?

Windows 11

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@qweeah qweeah added bug Something isn't working triage New issues or PRs to be acknowledged by maintainers labels Nov 25, 2024
@qweeah qweeah added this to the v1.3.0 milestone Nov 25, 2024
@FeynmanZhou FeynmanZhou modified the milestones: v1.3.0, v1.3.0-beta.1 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New issues or PRs to be acknowledged by maintainers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants