Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid using error-ignored functions to print warning #1446

Closed
qweeah opened this issue Jul 17, 2024 · 0 comments · Fixed by #1454
Closed

avoid using error-ignored functions to print warning #1446

qweeah opened this issue Jul 17, 2024 · 0 comments · Fixed by #1454
Labels
enhancement New feature or request

Comments

@qweeah
Copy link
Contributor

qweeah commented Jul 17, 2024 •
edited
Loading

Currently Command.PrintErrln and Command.PrintErrf are used to output deprecation and other warnings when Printer is not available in the context.

Should replace all usage of Command.PrintErrln and Command.PrintErrf.
@qweeah qweeah mentioned this issue Jul 17, 2024
Merged
@qweeah qweeah added good first issue Good for newcomers triage New issues or PRs to be acknowledged by maintainers enhancement New feature or request and removed triage New issues or PRs to be acknowledged by maintainers good first issue Good for newcomers labels Jul 17, 2024
@qweeah qweeah mentioned this issue Jul 23, 2024
Merged
@qweeah qweeah changed the title warning printing error should be handled avoid using error-ignored functions to print warning Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: replace error-ignored cobra output functions qweeah/oras
1 participant
@qweeah