Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradlew check doesn't detect mis-formatted JSON files #553

Open
mhalbritter opened this issue Oct 29, 2024 · 2 comments
Open

gradlew check doesn't detect mis-formatted JSON files #553

mhalbritter opened this issue Oct 29, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mhalbritter
Copy link
Collaborator

  1. ./gradlew scaffold --coordinates com.example:my-library:1.0.0
  2. Remove testImplementation "com.example:my-library:$libraryVersion" from build.gradle
  3. Edit metadata/com.example/my-library/1.0.0/index.json to look like this:
["jni-config.json","proxy-config.json","reflect-config.json","resource-config.json","serialization-config.json"]
  1. Run ./gradlew check

Expected: It should fail because the JSON is not formatted

Actual: Passes

@mhalbritter mhalbritter added the bug Something isn't working label Oct 29, 2024
@vjovanov
Copy link
Member

vjovanov commented Nov 4, 2024

@mhalbritter thanks for reporting! Is this issue blocking you?

@mhalbritter
Copy link
Collaborator Author

Nope, all good on my end. But until this is fixed, stuff on CI passes (meaning the PR will be green) even if the JSON is not well formatted - just something to keep an eye on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants