Unbinding $this of closure is deprecated on php 7.4

[oleghalin]

The issue is related to that closure was unserialized first, then Closure was serialized again and it doesn't have this attribute. Is there a way to bind $this to newly serialized closure?

basically here is 2 Closures, which I try to serialize. I figured out that issue is related to "isBindingRequired" is false for a second.

[aliwesome]

I have same issue.

[e1himself]

Same issue. Had to rewrite the code without using $this.

[e1himself]

I've narrowed the root cause to the fact that isBindingRequired property is calculated during ReflectionClosure::getCode() parsing. But parsing is skipped altogether when you get a reflector for an unserialized SerializedClosure that already has non-null $this->code value:

closure/src/SerializableClosure.php

Lines 89 to 102 in 628cc76

	/**
	* Get the reflector for closure
	*
	* @return ReflectionClosure
	*/
	public function getReflector()
	{
	if ($this->reflector === null) {
	$this->reflector = new ReflectionClosure($this->closure, $this->code);
	$this->code = null;
	}
	return $this->reflector;
	}

closure/src/ReflectionClosure.php

Lines 31 to 41 in 628cc76

	/**
	* ReflectionClosure constructor.
	* @param Closure $closure
	* @param string|null $code
	* @throws \ReflectionException
	*/
	public function __construct(Closure $closure, $code = null)
	{
	$this->code = $code;
	parent::__construct($closure);
	}

closure/src/ReflectionClosure.php

Lines 68 to 80 in 628cc76

	/**
	* @return string
	*/
	public function getCode()
	{
	if($this->code !== null){
	return $this->code;
	}
	$fileName = $this->getFileName();
	$line = $this->getStartLine() - 1;
	$match = ClosureStream::STREAM_PROTO . '://';

[oleghalin]

Yeah, i saw it too. It will be serialized, but $this will not be attach as scope to new serialized closure.

[e1himself]

Thanks a lot @msarca! 🎉