diff --git a/module/zfs/dnode.c b/module/zfs/dnode.c index 7ae74ad1318d..9da35742b446 100644 --- a/module/zfs/dnode.c +++ b/module/zfs/dnode.c @@ -1778,31 +1778,15 @@ dnode_try_claim(objset_t *os, uint64_t object, int slots) } /* - * Checks if the dnode itself is dirty, or is carrying any uncommitted records. - * It is important to check both conditions, as some operations (eg appending - * to a file) can dirty both as a single logical unit, but they are not synced - * out atomically, so checking one and not the other can result in an object - * appearing to be clean mid-way through a commit. - * - * Do not change this lightly! If you get it wrong, dmu_offset_next() can - * detect a hole where there is really data, leading to silent corruption. + * Check if the dnode (including its data) is dirty on this or any future txg. */ boolean_t dnode_is_dirty(dnode_t *dn) { mutex_enter(&dn->dn_mtx); - - for (int i = 0; i < TXG_SIZE; i++) { - if (multilist_link_active(&dn->dn_dirty_link[i]) || - !list_is_empty(&dn->dn_dirty_records[i])) { - mutex_exit(&dn->dn_mtx); - return (B_TRUE); - } - } - + boolean_t dirty = DNODE_IS_DIRTY(dn); mutex_exit(&dn->dn_mtx); - - return (B_FALSE); + return (dirty); } void