Skip to content
This repository has been archived by the owner on Nov 8, 2023. It is now read-only.

[Feature] Add webhook for edgex #22

Closed
gnunu opened this issue May 31, 2022 · 2 comments · Fixed by #48
Closed

[Feature] Add webhook for edgex #22

gnunu opened this issue May 31, 2022 · 2 comments · Fixed by #48
Assignees
@LindaYu17
Labels
enhancement New feature or request

Comments

@gnunu
Copy link
Member

gnunu commented May 31, 2022

No description provided.

@gnunu
Copy link
Member Author

gnunu commented May 31, 2022

Add defaulting and validating webhooks for edgex-manger.

@lwmqwer lwmqwer assigned lwmqwer and LindaYu17 and unassigned lwmqwer May 31, 2022
@lwmqwer lwmqwer moved this to In Progress in IoT-v0.3 Jun 5, 2022
@lwmqwer lwmqwer added this to IoT-v0.3 Jun 5, 2022
@lwmqwer
Copy link
Member

lwmqwer commented Jun 7, 2022 •
edited
Loading

Add defaulting and validating webhooks for edgex-manger.

The webhook default part should set the version to jakarda and ServiceType to clusterip

The validation part should verify the version is hanoi or jakarda,
poolname is a right nodepool name and no other edgex in the same nodepool
Could refer this PR #17
Service type is clusterip or nodeport.

Add some case in the e2e is a great practice.

@lwmqwer lwmqwer added the enhancement New feature or request label Jun 7, 2022
@Rui-Gan Rui-Gan mentioned this issue Oct 1, 2022
Merged
Repository owner moved this from In Progress to Done in IoT-v0.3 Oct 4, 2022
@lwmqwer lwmqwer removed this from IoT-v0.3 Oct 12, 2022
@lwmqwer lwmqwer moved this to Done in IoT-v0.2 Oct 12, 2022
@lwmqwer lwmqwer added this to IoT-v0.2 Oct 12, 2022
@Rui-Gan Rui-Gan mentioned this issue Feb 15, 2023
Closed
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LindaYu17 LindaYu17

Labels
enhancement New feature or request
Projects
No open projects
IoT-v0.2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add webhook for edgex and complete yurt-edgex-manager deployment by helm Rui-Gan/yurt-edgex-manager
3 participants
@gnunu @LindaYu17 @lwmqwer