Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Why not check is-edge-worker==true #488

Closed
adamzhoul opened this issue Sep 22, 2021 · 3 comments
Closed

[Question] Why not check is-edge-worker==true #488

adamzhoul opened this issue Sep 22, 2021 · 3 comments
Labels
kind/question kind/question

Comments

@adamzhoul
Copy link
Member

image

_, ok := node.Labels[projectinfo.GetEdgeWorkerLabelKey()]

what if labed "openyurt.io/is-edge-worker:true" :


			v, ok := node.Labels[projectinfo.GetEdgeWorkerLabelKey()]
			if !ok {
				edgeNodeNames = append(edgeNodeNames, node.GetName())
			}else if v == "true“ {
                               	edgeNodeNames = append(edgeNodeNames, node.GetName())
                         }


similarity question at:

_, ok := node.Labels[projectinfo.GetEdgeWorkerLabelKey()]

@adamzhoul adamzhoul added the kind/question kind/question label Sep 22, 2021
@rambohe-ch
Copy link
Member

@Peeknut Do you have any comments?

@Peeknut
Copy link
Member

Peeknut commented Sep 22, 2021

I think if the node has the label "openyurt.io/is-edge-worker:true", it doesn't need to do the convert, because it's already a yurt node.

@adamzhoul
Copy link
Member Author

got it.
thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question kind/question
Projects
None yet
Development

No branches or pull requests

3 participants