Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images are not updated automatically anymore #622

Closed
lucacome opened this issue Jun 4, 2024 · 4 comments · Fixed by #642
Closed

Docker images are not updated automatically anymore #622

lucacome opened this issue Jun 4, 2024 · 4 comments · Fixed by #642

Comments

@lucacome
Copy link
Member

lucacome commented Jun 4, 2024

After #606

  • dependabot is not been able to automatically update the Dockerfile anymore
  • the workflow that keeps the images up to date is not working anymore.
@lucacome
Copy link
Member Author

lucacome commented Jun 4, 2024

What was the reason for the change @miry ?

@miry
Copy link
Collaborator

miry commented Jun 4, 2024

@lucacome it was problem with building a new image as I could remember.

As I understand the https://github.com/opentracing-contrib/nginx-opentracing/pull/606/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L204 pointed to bookworm

but we used bullseye for repo: https://github.com/opentracing-contrib/nginx-opentracing/pull/606/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557L206

@lucacome can you share what worklfows were impacted?

UPDATE: Found why I made a change: #605 , I expected it would detect the changes with docker image tag as it does for alpine.

@lucacome
Copy link
Member Author

lucacome commented Jun 6, 2024

@miry dependabot doesn't resolve the ARGs unfortunately. Also this workflow https://github.com/opentracing-contrib/nginx-opentracing/actions/workflows/update-docker-images.yml has been failing.

I can update it to make it work again, I just wanted to know the reason for the change before starting to work on it.

@miry
Copy link
Collaborator

miry commented Jun 6, 2024

@lucacome my bad :( . pls fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants