Unexpected error using gcc-8

[aledbf]

In file included from src/core/ngx_core.h:51,
                 from /tmp/build/nginx-opentracing-0.5.0/opentracing/src/opentracing_directive.h:6,
                 from /tmp/build/nginx-opentracing-0.5.0/opentracing/src/opentracing_directive.cpp:1:
/tmp/build/nginx-opentracing-0.5.0/opentracing/src/opentracing_directive.cpp: In function 'char* ngx_opentracing::add_opentracing_tag(ngx_conf_t*, ngx_array_t*, ngx_str_t, ngx_str_t)':
src/core/ngx_string.h:88:58: error: 'void* memset(void*, int, size_t)' clearing an object of non-trivial type 'struct ngx_opentracing::opentracing_tag_t'; use assignment or value-initialization instead [-Werror=class-memaccess]
 #define ngx_memzero(buf, n)       (void) memset(buf, 0, n)
                                                          ^
/tmp/build/nginx-opentracing-0.5.0/opentracing/src/opentracing_directive.cpp:92:3: note: in expansion of macro 'ngx_memzero'
   ngx_memzero(tag, sizeof(opentracing_tag_t));
   ^~~~~~~~~~~
In file included from /tmp/build/nginx-opentracing-0.5.0/opentracing/src/opentracing_directive.cpp:5:
/tmp/build/nginx-opentracing-0.5.0/opentracing/src/opentracing_conf.h:13:8: note: 'struct ngx_opentracing::opentracing_tag_t' declared here
 struct opentracing_tag_t {
        ^~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
make[1]: *** [objs/Makefile:2716: objs/addon/src/opentracing_directive.o] Error 1

[rnburn]

@aledbf - can you try the change in #51?

I build with gcc8 as part of the test coverage, but the error doesn't show it with that version of gcc8.

[aledbf]

can you try the change in #51?

It works 👍