Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat Request: Support W3C Trace Context header #132

Closed
Renz2018 opened this issue Jul 1, 2020 · 6 comments
Closed

Feat Request: Support W3C Trace Context header #132

Renz2018 opened this issue Jul 1, 2020 · 6 comments

Comments

@Renz2018
Copy link

Renz2018 commented Jul 1, 2020

W3C trace context now is "W3C Recommendation 06 February 2020"
But nginx-opentracing support B3 and jaeger, not support w3c trace context.
I know opentelemetry support W3c trace context dafault, but still many people use nginx-opentracing( specaily nginx-ingress-controller)

@robermorales
Copy link

+1

@miry
Copy link
Collaborator

miry commented Dec 4, 2020

@ovidiubuligan
Copy link

I also need this with a aspnet core backend . The backend only knows how to get the parent context if it is in W3C format.

@miry
Copy link
Collaborator

miry commented Dec 8, 2020

I have successfully upgraded jaeger tracer to custom branch: master...miry:upgrade-jeager-opentracing

It generates W3C format headers.
Going to prepare a PR.

Also there is an improvement PR to have trace 128 bits jaegertracing/jaeger-client-cpp#254

@miry
Copy link
Collaborator

miry commented Dec 16, 2020

Created a sample PR #147 to show how it is possible to use latest Jaeger with W3C. There are no any changes required in nginx-opentracing code.
Working on patching nginx-ingress to support latest libs.

@miry
Copy link
Collaborator

miry commented Apr 17, 2021

Jeager tracing released a new version where it supports W3C headers.
Ingress-nginx master has changes with latest jaeger.
So now it is possible to use nginx-opentracing with a new Jaeger and support W3C headers.

@miry miry closed this as completed Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants