diff --git a/opentracing-spring-web-itest/common/src/test/java/io/opentracing/contrib/spring/web/interceptor/itest/common/AbstractBaseITests.java b/opentracing-spring-web-itest/common/src/test/java/io/opentracing/contrib/spring/web/interceptor/itest/common/AbstractBaseITests.java index b08b4631..991d914f 100644 --- a/opentracing-spring-web-itest/common/src/test/java/io/opentracing/contrib/spring/web/interceptor/itest/common/AbstractBaseITests.java +++ b/opentracing-spring-web-itest/common/src/test/java/io/opentracing/contrib/spring/web/interceptor/itest/common/AbstractBaseITests.java @@ -1,5 +1,5 @@ /** - * Copyright 2016-2019 The OpenTracing Authors + * Copyright 2016-2020 The OpenTracing Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at @@ -20,7 +20,6 @@ import io.opentracing.mock.MockSpan; import io.opentracing.tag.Tags; import org.awaitility.Awaitility; -import org.awaitility.Duration; import org.hamcrest.core.IsEqual; import org.junit.Assert; import org.junit.Before; @@ -30,6 +29,7 @@ import org.springframework.boot.test.web.client.TestRestTemplate; import org.springframework.http.*; +import java.time.Duration; import java.util.Arrays; import java.util.Collections; import java.util.HashSet; @@ -47,7 +47,7 @@ public abstract class AbstractBaseITests { @BeforeClass public static void beforeClass() throws Exception { - Awaitility.setDefaultTimeout(Duration.FIVE_SECONDS); + Awaitility.setDefaultTimeout(Duration.ofSeconds(5)); } @Before diff --git a/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithContextPathAndBasePathTest.java b/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithContextPathAndBasePathTest.java index de3b9b18..28609c2f 100644 --- a/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithContextPathAndBasePathTest.java +++ b/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithContextPathAndBasePathTest.java @@ -1,5 +1,5 @@ /** - * Copyright 2016-2019 The OpenTracing Authors + * Copyright 2016-2020 The OpenTracing Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at @@ -119,12 +119,6 @@ public void testSkipInfoEndpoint() { assertNoSpans(); } - @Test - public void testSkipAuditEventsEndpoint() { - invokeEndpoint(AUDIT_EVENTS); - assertNoSpans(); - } - @Test public void testSkipMetricsEndpoint() { invokeEndpoint(METRICS+ "?abc"); diff --git a/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithContextPathWithoutBasePathTest.java b/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithContextPathWithoutBasePathTest.java index 72f29193..e7dbcd66 100644 --- a/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithContextPathWithoutBasePathTest.java +++ b/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithContextPathWithoutBasePathTest.java @@ -1,5 +1,5 @@ /** - * Copyright 2016-2019 The OpenTracing Authors + * Copyright 2016-2020 The OpenTracing Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at @@ -117,12 +117,6 @@ public void testSkipInfoEndpoint() { assertNoSpans(); } - @Test - public void testSkipAuditEventsEndpoint() { - invokeEndpoint(AUDIT_EVENTS); - assertNoSpans(); - } - @Test public void testTraceHelloEndpoint() { invokeEndpoint(HELLO); diff --git a/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithoutContextPathAndBasePathTest.java b/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithoutContextPathAndBasePathTest.java index 07d03fbc..1c8503e8 100644 --- a/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithoutContextPathAndBasePathTest.java +++ b/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithoutContextPathAndBasePathTest.java @@ -1,5 +1,5 @@ /** - * Copyright 2016-2019 The OpenTracing Authors + * Copyright 2016-2020 The OpenTracing Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at @@ -118,12 +118,6 @@ public void testSkipInfoEndpoint() { assertNoSpans(); } - @Test - public void testSkipAuditEventsEndpoint() { - invokeEndpoint(AUDIT_EVENTS); - assertNoSpans(); - } - @Test public void testSkipMetricsEndpoint() { invokeEndpoint(METRICS + "?abc"); diff --git a/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithoutContextPathAndWithoutBasePathTest.java b/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithoutContextPathAndWithoutBasePathTest.java index 21eed3be..b169efcc 100644 --- a/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithoutContextPathAndWithoutBasePathTest.java +++ b/opentracing-spring-web-starter/src/test/java/io/opentracing/contrib/spring/web/starter/SkipEndPointsWithoutContextPathAndWithoutBasePathTest.java @@ -1,5 +1,5 @@ /** - * Copyright 2016-2019 The OpenTracing Authors + * Copyright 2016-2020 The OpenTracing Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at @@ -113,12 +113,6 @@ public void testSkipInfoEndpoint() { assertNoSpans(); } - @Test - public void testSkipAuditEventsEndpoint() { - invokeEndpoint(AUDIT_EVENTS); - assertNoSpans(); - } - @Test public void testSkipMetricsEndpoint() { invokeEndpoint(METRICS + "?abc"); diff --git a/opentracing-spring-web/pom.xml b/opentracing-spring-web/pom.xml index 531dadd6..620a1776 100644 --- a/opentracing-spring-web/pom.xml +++ b/opentracing-spring-web/pom.xml @@ -73,5 +73,10 @@ ${version.io.projectreactor.netty-reactor-netty} test + + org.awaitility + awaitility + test + diff --git a/opentracing-spring-web/src/test/java/io/opentracing/contrib/spring/web/client/AbstractTracingClientTest.java b/opentracing-spring-web/src/test/java/io/opentracing/contrib/spring/web/client/AbstractTracingClientTest.java index c292ea92..6ee58bde 100644 --- a/opentracing-spring-web/src/test/java/io/opentracing/contrib/spring/web/client/AbstractTracingClientTest.java +++ b/opentracing-spring-web/src/test/java/io/opentracing/contrib/spring/web/client/AbstractTracingClientTest.java @@ -1,5 +1,5 @@ /** - * Copyright 2016-2019 The OpenTracing Authors + * Copyright 2016-2020 The OpenTracing Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at @@ -38,6 +38,8 @@ import static com.github.tomakehurst.wiremock.client.WireMock.stubFor; import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; import static com.github.tomakehurst.wiremock.core.WireMockConfiguration.wireMockConfig; +import static java.util.concurrent.TimeUnit.SECONDS; +import static org.awaitility.Awaitility.await; /** * @author Pavol Loffay @@ -169,6 +171,11 @@ public void testErrorUnknownHostException() { //ok UnknownHostException } + await().atMost(5, SECONDS).until(() -> { + List mockSpans = mockTracer.finishedSpans(); + return mockSpans.size() == 1; + }); + List mockSpans = mockTracer.finishedSpans(); Assert.assertEquals(1, mockSpans.size()); diff --git a/pom.xml b/pom.xml index 1df98eeb..55e8fad0 100644 --- a/pom.xml +++ b/pom.xml @@ -57,18 +57,18 @@ UTF-8 ${project.basedir} - 3.0.0 + 4.0.3 0.33.0 0.4.0 0.1.8 0.3.1 4.12 2.23.4 - 2.1.6.RELEASE + 2.3.4.RELEASE - 5.1.8.RELEASE + 5.2.9.RELEASE 2.21.0 - 0.8.5.RELEASE + 0.9.12.RELEASE 2.8.2 @@ -135,6 +135,12 @@ mockito-core ${version.org.mockito-mockito-core} + + + org.awaitility + awaitility + ${version.org.awaitility-awaitility} +