New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circular inclusion on tools.hpp/remove const ref from string view #3019

Merged

dudantas merged 5 commits into main from dudantas/fix-circular-inclusion-on-tools

Oct 26, 2024

Merged

fix: circular inclusion on tools.hpp/remove const ref from string view #3019

Merge branch 'main' into dudantas/fix-circular-inclusion-on-tools

GitHub Actions / cppcheck completed Oct 26, 2024 in 0s

reviewdog [cppcheck] report

reported by reviewdog 🐶

Findings (4)

src/creatures/players/wheel/player_wheel.cpp|99| Function parameter 'spellName' should be passed by const reference.
src/creatures/players/wheel/player_wheel.cpp|115| Function parameter 'spellName' should be passed by const reference.
src/lib/metrics/metrics.hpp|58| Function parameter 'name' should be passed by const reference.
src/lib/metrics/metrics.cpp|90| Function parameter 'name' should be passed by const reference.

Filtered Findings (0)

Annotations

Check warning on line 99 in src/creatures/players/wheel/player_wheel.cpp

github-actions / cppcheck

[cppcheck] src/creatures/players/wheel/player_wheel.cpp#L99

Function parameter 'spellName' should be passed by const reference.

Raw output


            src/creatures/players/wheel/player_wheel.cpp:99:Function parameter 'spellName' should be passed by const reference.

Check warning on line 115 in src/creatures/players/wheel/player_wheel.cpp

github-actions / cppcheck

[cppcheck] src/creatures/players/wheel/player_wheel.cpp#L115

Function parameter 'spellName' should be passed by const reference.

Raw output


            src/creatures/players/wheel/player_wheel.cpp:115:Function parameter 'spellName' should be passed by const reference.

Check warning on line 58 in src/lib/metrics/metrics.hpp

github-actions / cppcheck

[cppcheck] src/lib/metrics/metrics.hpp#L58

Function parameter 'name' should be passed by const reference.

Raw output


            src/lib/metrics/metrics.hpp:58:Function parameter 'name' should be passed by const reference.

Check warning on line 90 in src/lib/metrics/metrics.cpp

github-actions / cppcheck

[cppcheck] src/lib/metrics/metrics.cpp#L90

Function parameter 'name' should be passed by const reference.

Raw output


            src/lib/metrics/metrics.cpp:90:Function parameter 'name' should be passed by const reference.

View more details on GitHub Actions