Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protection imbuement % does not appear in combat stats page #270

Closed
1 task done
guispiller opened this issue Jan 29, 2022 · 2 comments · Fixed by #819
Closed
1 task done

Protection imbuement % does not appear in combat stats page #270

guispiller opened this issue Jan 29, 2022 · 2 comments · Fixed by #819
Labels
Area: Source Priority: Medium This issue may be impactful and needs some attention. Stale No activity Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@guispiller
Copy link
Contributor

What happened?

When you equip an equipment with any imbuement protection, this protection percentage is not showed in combat stats page, on character's cyclopedia

How to Reproduce?

Equip any equipment with elemental imbuement protection, and open your cyclopedia > character > combat stats. This percentage is not shown.

Relevant log output

No response

Attach any relevant file

image

Version

12.x (Default)

What OS are you seeing the problem on?

Ubuntu 18.04, Windows 10

Code of Conduct

  • I agree to follow this project's Code of Conduct
@guispiller guispiller added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label Jan 29, 2022
@guispiller
Copy link
Contributor Author

It was an issue in otbr source, but is still an issue in canary source. Please, move it to canary repo.

@majestyotbr majestyotbr transferred this issue from opentibiabr/otservbr-global Mar 14, 2022
@andersonfaaria andersonfaaria added Priority: Medium This issue may be impactful and needs some attention. Area: Source labels Apr 5, 2022
@andersonfaaria andersonfaaria changed the title [Bug]: Protection imbuement % does not appear in combat stats page Protection imbuement % does not appear in combat stats page Apr 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

This issue is stale because it has been open 120 days with no activity.

@github-actions github-actions bot added the Stale No activity label Jul 5, 2022
@guispiller guispiller mentioned this issue Aug 24, 2022
Closed
5 tasks
@murilo09 murilo09 linked a pull request Jan 27, 2023 that will close this issue
fix: display imbuement damage reductions in cyclopedia #819
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Source Priority: Medium This issue may be impactful and needs some attention. Stale No activity Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: display imbuement damage reductions in cyclopedia ElimarCosta/canary
2 participants
@andersonfaaria @guispiller