Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash on disconnect #1143

Closed
2 of 5 tasks
Tracked by #1144
aokisama opened this issue May 29, 2023 · 1 comment · Fixed by #1144
Closed
2 of 5 tasks
Tracked by #1144

Crash on disconnect #1143

aokisama opened this issue May 29, 2023 · 1 comment · Fixed by #1144
Labels
Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@aokisama
Copy link
Contributor

aokisama commented May 29, 2023

Priority

High

Area

  • Datapack
  • Source
  • Map
  • Other

What happened?

The player says that he went offline training on one char then he logged into another character with same account and thats when the server crashed.

I believe the changes from #1117 might be related but I'm not 100% sure.

2023-05-29 20:37:28 - #0 0x000055555572ed68 in Protocol::disconnect (this=0x2060706d61765f65) at /usr/include/c++/11/bits/shared_ptr_base.h:1347
2023-05-29 20:37:28 - No locals.
2023-05-29 20:37:28 - #1 0x00005555558c14c5 in Player::disconnect (this=, this=) at /root/canary/src/creatures/players/player.h:405
2023-05-29 20:37:28 - No locals.
2023-05-29 20:37:28 - #2 ProtocolGame::login (this=0x7fffd6a84b00, name="Healer", accountId=715, operatingSystem=) at /root/canary/src/server/network/protocol/protocolgame.cpp:406

What OS are you seeing the problem on?

Linux

Code of Conduct

  • I agree to follow this project's Code of Conduct
@aokisama aokisama added the Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. label May 29, 2023
@github-actions github-actions bot added Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing labels May 29, 2023
@aokisama
Copy link
Contributor Author

In config lua set

replaceKickOnLogin = true

If you try to CTRL + G a lot of times and switch between characters eventually this message will come up:

[2023-30-05 09:08:13.447] [error] Attempted to get player with empty name string

the server will then hangup and not let anybody else connect.

@beats-dh beats-dh linked a pull request May 30, 2023 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Represent a high impact in key areas of the base/user experience Status: Pending Test This PR or Issue requires more testing Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant