Versioned Docker images

[ShonP40]

Could you guys upload versioned Docker images & GitHub releases in addition to the latest image? (e.g. openspeedtest:1.0.0)

This would allow me to add OpenSpeedTest to Umbrel with the ability to update it without needing to reinstall it.

See https://github.com/ShonP40/umbrel-apps/tree/master/shonp40-home-assistant as an example

[openspeedtest]

openspeedtest/latest:latest to openspeedtest/latest:v2.5.4

[ShonP40]

Should probably be <organization>/<app>:<version>

[openspeedtest]

Creating new images will confuse people.
No breaking changes will be introduced to this image.
latest is the app name, which is not ideal, but that is what I chose when I created this.
I was planning to add something like this openspeedtest/latest:v2.5.4

Did you try this?

pull_policy: always

version: '3.3'
services:
    speedtest:
        restart: unless-stopped
        container_name: openspeedtest
        ports:
            - '3000:3000'
            - '3001:3001'
        image: openspeedtest/latest
        pull_policy: always

https://stackoverflow.com/a/66136860/16065516

If that is not working, we can add a new tag with the version name.
openspeedtest/latest:v2.5.4

[ShonP40]

The goal is to have Umbrel know when there’s an update.
Not to just randomly update images without letting the user know.

So yea, having openspeedtest/latest:v2.5.4 will do the job

[ShonP40]

will you be able to publish GitHub releases with the version number as well?

My auto updating repo is currently using GitHub’s API to fetch the latest version number of an app, as well as Docker Hub’s API to fetch the image’s digest.

So I kinda need both GitHub releases and versioned Docker images.

[openspeedtest]

nginxinc/nginx-unprivileged updated two days ago, mostly security updates.
So every time, do we need to increase the version number? Most of the time, we don't have any app updates. Just upstream image updates.

[ShonP40]

oh, I thought that you’re building the image if you need to upgrade dependencies

[ShonP40]

well, is it really needed to bump the release number on every third party image update though?
unless you actually need to change something in the image, I don’t think that there’s a need to bump the version number when nginxinc/nginx-unprivileged releases an update.

Users aren’t aware of these third party updates anyways until they restart the container. And even then it doesn’t always upgrade base images

[openspeedtest]

This is oky? https://github.com/openspeedtest/Docker-Image/releases

[ShonP40]

Yea

[ShonP40]

You don’t actually need to have files on it
Just the correct version number

[ShonP40]

Like, the version number should match between GitHub and Docker

[openspeedtest]

done. https://hub.docker.com/layers/openspeedtest/latest/v0.0.1/images/sha256-86403b1f20989db6d817c6a739907d12ef5532c4a4edbd711c287f11d59f2780?context=repo
That is files without '.' folders. Including git history.

[ShonP40]

Seems fine to me

[ShonP40]

I’ll implement it into my own Umbrel repo first and then maybe we can make a PR on Umbrel’s official repo for it

[openspeedtest]

Did you fix the upload issue?

[ShonP40]

I actually kinda forgot about it as I haven’t been using my Umbrel instance for a while & got busy with some other projects lol (I want to rebuild the portable server it’s in right now to make it smaller)

[openspeedtest]

OK, we need to increase post body content length / request buffering

caddy

    reverse_proxy http://localhost:3000 {
         buffer_requests
         buffer_responses
         flush_interval -1
         max_buffer_size 35MiB
        }

other reverse proxy fix openspeedtest/Speed-Test#4 (comment)

[ShonP40]

Yea I know that, but I have no idea where I can edit that on Umbrel’s proxy
getumbrel/umbrel#1560

[ShonP40]

Just tried my auto updates action on it and it works

[ShonP40]

Hey, any chance you could actually change the version number on Docker hub & GitHub every time you push an update?
Keeping it on 0.0.1 all the time isn't going to trigger Umbrel's auto updates

[openspeedtest]

Definitely do it when I actually update the application. Last updates are just rerun. Nothing changed.

[ShonP40]

ah, I’ve just been seeing my auto updater action triggering a few times and still keeping the 0.0.1 version number so that’s why I mentioned it here