From 291eb224806ff6396fcc8691bcab36fe727d45cd Mon Sep 17 00:00:00 2001 From: Jerop Kipruto Date: Thu, 13 Jan 2022 14:12:40 -0500 Subject: [PATCH] `Timeout` and `TaskSpec` supported in `Custom Tasks` We already designed and implemented support for `Timeouts` and `TaskSpec` in `Custom Tasks`. `Timeouts`: - TEP: https://github.com/tektoncd/community/pull/433 - PR: https://github.com/tektoncd/pipeline/pull/3976 `TaskSpec`: - TEP: https://github.com/tektoncd/community/blob/main/teps/0061-allow-custom-task-to-be-embedded-in-pipeline.md - PR: https://github.com/tektoncd/pipeline/pull/3901 This item cleans up the todo items in `RunSpec`. --- pkg/apis/pipeline/v1alpha1/run_types.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/pkg/apis/pipeline/v1alpha1/run_types.go b/pkg/apis/pipeline/v1alpha1/run_types.go index dba337d9a2f..5ec4f199c80 100644 --- a/pkg/apis/pipeline/v1alpha1/run_types.go +++ b/pkg/apis/pipeline/v1alpha1/run_types.go @@ -78,10 +78,6 @@ type RunSpec struct { // Workspaces is a list of WorkspaceBindings from volumes to workspaces. // +optional Workspaces []v1beta1.WorkspaceBinding `json:"workspaces,omitempty"` - - // TODO(https://github.com/tektoncd/community/pull/128) - // - timeout - // - inline task spec } // RunSpecStatus defines the taskrun spec status the user can provide