image: Switch to ostree-format: oci
#611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the RHCOS version of coreos/fedora-coreos-config#1097 I was hoping to land this in FCOS first but I'm kind of blocked on that in coreos/fedora-coreos-pipeline#359, so let's settle for parallel. NOTE! This **does not change** the effect of `cosa upload-oscontainer` etc. Some discussion on that here: ostreedev/ostree-rs-ext#23 and I will file more issues related to that. However, what this *will* do is allow us to push this *additional* image arounnd and make `podman run registry.ci.openshift.org/rhcos/rhcos:4.8` e.g. work. In other words to start this will just be something *we* use to quickly inspect rhcos-as-container, not something we actually ship. (OK that's kind of a lie, it will end up in a place like e.g. http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/ instead of the existing `ostree.tar` so in theory other people outside of our group could run it too, but 🤫)
miabbott
approved these changes
Sep 1, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
reverted in #613 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-submit; we reverted in #601
but the issue is fixed with newer rpm-ostree.
This is the RHCOS version of coreos/fedora-coreos-config#1097
I was hoping to land this in FCOS first but I'm kind of blocked
on that in coreos/fedora-coreos-pipeline#359, so
let's settle for parallel.
NOTE! This does not change the effect of
cosa upload-oscontaineretc.Some discussion on that here:
ostreedev/ostree-rs-ext#23
and I will file more issues related to that.
However, what this will do is allow us to push this additional image
arounnd and make
podman run registry.ci.openshift.org/rhcos/rhcos:4.8e.g.work. In other words to start this will just be something we use
to quickly inspect rhcos-as-container, not something we actually ship.
(OK that's kind of a lie, it will end up in a place like e.g.
http://mirror.openshift.com/pub/openshift-v4/dependencies/rhcos/pre-release/4.9.0-0.nightly-2021-07-20-014024/
instead of the existing
ostree.tarso in theory other people outsideof our group could run it too, but 🤫)