Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manifest: chmod 600 /etc/sudoers.d/* #579

Closed
wants to merge 1 commit into from
Closed

manifest: chmod 600 /etc/sudoers.d/* #579

wants to merge 1 commit into from

Conversation

bgilbert
Copy link
Contributor

Apparently there are security scanners that object to mode 644.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1981979.

Apparently there are security scanners that object to mode 644.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1981979.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgilbert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from sohankunkerkar and travier July 13, 2021 22:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@miabbott
Copy link
Member

The same permissions exist on FCOS; I think this should be moved to fedora-coreos-config

@jlebon
Copy link
Member

jlebon commented Jul 14, 2021

Wonder at this point if it'd be cleaner to just support a statoverride file at e.g. overlay.d/stat-override.txt that we just feed to ostree while committing the overlays in cosa.

@bgilbert
Copy link
Contributor Author

Moved to fedora-coreos-config in coreos/fedora-coreos-config#1111, using statoverride support added in coreos/coreos-assembler#2293.

@bgilbert bgilbert closed this Jul 14, 2021
@bgilbert bgilbert deleted the sudoers-security-theater branch July 14, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants