From 66ef1dbcebce0d6cdaf624a0d4fb3ca3b16fc5c1 Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Fri, 2 Sep 2016 09:51:09 -0400 Subject: [PATCH] Warn if no login idps are present --- pkg/cmd/server/api/validation/oauth.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/cmd/server/api/validation/oauth.go b/pkg/cmd/server/api/validation/oauth.go index ba07d1e23ba0..62c835ffcf21 100644 --- a/pkg/cmd/server/api/validation/oauth.go +++ b/pkg/cmd/server/api/validation/oauth.go @@ -86,6 +86,9 @@ func ValidateOAuthConfig(config *api.OAuthConfig, fldPath *field.Path) Validatio } } + if len(redirectingIdentityProviders) == 0 { + validationResults.AddWarnings(field.Invalid(fldPath.Child("identityProviders"), "login", "no identity providers are configured to handle logins")) + } if len(challengeRedirectingIdentityProviders) > 1 { validationResults.AddErrors(field.Invalid(fldPath.Child("identityProviders"), "challenge", fmt.Sprintf("only one identity provider can redirect clients requesting an authentication challenge, found: %v", strings.Join(challengeRedirectingIdentityProviders, ", ")))) }