Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop oidc-ca.crt? #564

Closed
wking opened this issue Oct 29, 2018 · 1 comment
Closed

Drop oidc-ca.crt? #564

wking opened this issue Oct 29, 2018 · 1 comment

Comments

@wking
Copy link
Member

wking commented Oct 29, 2018

We set this in both kube-apiserver-secret.go and openshift-apiserver-secret.go, and we started setting this in db65ea2 (coreos/tectonic-installer#1811). But we have been using the kube-ca value for it since at least 4d636d3 (#286) and I see no other OpenShift consumers. Can we drop the setting?
@abhinavdahiya
Copy link
Contributor

abhinavdahiya commented Oct 29, 2018 •
edited
Loading

Lets drop it and ci failure o the PR will be our gate :P

@wking wking mentioned this issue Oct 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wking @abhinavdahiya