Skip to content

Commit 5d17b14

Browse files
Merge pull request #927 from wking/aws-public-worker-ips
pkg/asset/machines/aws/machinesets: Give workers public IPs (for now)
2 parents 1a37abb + 0055276 commit 5d17b14

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

pkg/asset/machines/aws/machinesets.go

+13
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ import (
66

77
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
88
"k8s.io/apimachinery/pkg/runtime"
9+
"k8s.io/utils/pointer"
10+
awsprovider "sigs.k8s.io/cluster-api-provider-aws/pkg/apis/awsproviderconfig/v1alpha1"
911
clusterapi "sigs.k8s.io/cluster-api/pkg/apis/cluster/v1alpha1"
1012

1113
"github.com/openshift/installer/pkg/types"
@@ -88,3 +90,14 @@ func MachineSets(config *types.InstallConfig, pool *types.MachinePool, role, use
8890

8991
return machinesets, nil
9092
}
93+
94+
// ConfigWorkers sets the PublicIP flag for the given machine sets.
95+
//
96+
// Deprecated: We'll remove this once the e2e tests no longer require
97+
// worker SSH access.
98+
func ConfigWorkers(machineSets []clusterapi.MachineSet) {
99+
for _, machineSet := range machineSets {
100+
providerConfig := machineSet.Spec.Template.Spec.ProviderConfig.Value.Object.(*awsprovider.AWSMachineProviderConfig)
101+
providerConfig.PublicIP = pointer.BoolPtr(true)
102+
}
103+
}

pkg/asset/machines/worker.go

+1
Original file line numberDiff line numberDiff line change
@@ -100,6 +100,7 @@ func (w *Worker) Generate(dependencies asset.Parents) error {
100100
if err != nil {
101101
return errors.Wrap(err, "failed to create worker machine objects")
102102
}
103+
aws.ConfigWorkers(sets)
103104

104105
list := listFromMachineSets(sets)
105106
raw, err := yaml.Marshal(list)

0 commit comments

Comments
 (0)