Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add integration tests across the compatibility matrix #12

Closed
dblock opened this issue Oct 10, 2022 · 5 comments · Fixed by #21
Closed

[FEATURE] Add integration tests across the compatibility matrix #12

dblock opened this issue Oct 10, 2022 · 5 comments · Fixed by #21
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Oct 10, 2022

Is your feature request related to a problem?

We document the following compatibility matrix, https://github.com/opensearch-project/spring-data-opensearch#compatibility-matrix. But does it really work?

What solution would you like?

Add integration tests that boot OpenSearch containers and test this project against it.

@dblock dblock added the enhancement New feature or request label Oct 10, 2022
@rursprung
Copy link

it currently lists OpenSearch 1.x as being compatible, does that mean that it should also be compatible with ES 7.10.2? that'd be perfect, to have a clear migration roadmap (i.e. update clients first, then the server; otherwise a lock-step upgrade would be needed)

@dblock
Copy link
Member Author

dblock commented Oct 11, 2022

it currently lists OpenSearch 1.x as being compatible, does that mean that it should also be compatible with ES 7.10.2? that'd be perfect, to have a clear migration roadmap (i.e. update clients first, then the server; otherwise a lock-step upgrade would be needed)

@reta do you know? we should add integ tests anyway if we want to make sure

@reta
Copy link
Collaborator

reta commented Oct 11, 2022

The OpenSearch 1.x should be supported (I checked that at the time of original pull request) BUT there is one catch: the baseline JDK for the project is 17 (what I am trying to say is that it is very likely 2.0 would be the minimal OS version in the wild, I could be mistaken). Regarding, ES 7.10.2, I think it should be compatible (although I did not test that) but there is no real reason to use spring-data-opensearch: the spring-data-elasticsearch covers that (and the flip from ES to OS would be only minimal configuration changes).

@reta
Copy link
Collaborator

reta commented Oct 11, 2022

Add integration tests that boot OpenSearch containers and test this project against it.

@dblock we do that for 2.3, I will add the 1.3 shortly.

@rursprung
Copy link

Regarding, ES 7.10.2, I think it should be compatible (although I did not test that) but there is no real reason to use spring-data-opensearch: the spring-data-elasticsearch covers that (and the flip from ES to OS would be only minimal configuration changes).

the use-case for that would really be for migrations of current setups running with ES 7.10.2 & spring-data-elasticsearch: if you upgrade ES to OpenSearch 2.x first then spring-data-elasticsearch will fail. so to do this as an online migration (instead of a big-bang approach) you'd first upgrade the clients to use spring-data-opensearch and only afterwards do the ES to OpenSearch 2.x migration. not sure how many people have a need for that though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants