Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [CI] Tests under src/integrationTest folder not being executed in CI checks #2998

Closed
DarshitChanpura opened this issue Jul 12, 2023 · 1 comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.

Comments

@DarshitChanpura
Copy link
Member

DarshitChanpura commented Jul 12, 2023

Tests in folder https://github.com/opensearch-project/security/tree/main/src/integrationTest are not being run as part of current CI, after #2861 merge.

Steps to reproduce the behavior:

  1. As a first task in current CI run, ./gradlew listTasksAsJSON lists all test tasks to be executed
  2. This is the current output:
["citest","ciSecurityIntegrationTest","crossClusterTest","dlicDlsflsTest","dlicRestApiTest","indicesTest","opensslCITest","sslTest"]

These tasks currently don't touch files in the mentioned folder. They can be executed with ./gradlew integrationTest

Take these two tests for example: CrossClusterSearchTests.java , WhoAmITests.java
Task citest by definition covers all tests not covered in other test tasks, but when I run these two with ./gradlew citest --tests "..." these are the outputs:

> No tests found for given includes: [**/*.class](include rules) [**/*$*.class](exclude rules) [org.opensearch.security.CrossClusterSearchTests](--tests filter)
> No tests found for given includes: [**/*.class](include rules) [**/*$*.class](exclude rules) [org.opensearch.security.rest.WhoAmITests](--tests filter)

What is the expected behavior?
All the tests in the mentioned folder should run. Adding these tests should also boost coverage.

Solution

  1. Add integrationTest task as part of test tasks
    OR
  2. Modify ciSecurityIntegrationTest task to also include these files.
@DarshitChanpura DarshitChanpura added bug Something isn't working untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 12, 2023
@DarshitChanpura DarshitChanpura changed the title [BUG] [CI] Tests under src/integrationTest folder not being executing in CI [BUG] [CI] Tests under src/integrationTest folder not being executed in CI checks Jul 12, 2023
@DarshitChanpura DarshitChanpura added triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable. and removed untriaged Require the attention of the repository maintainers and may need to be prioritized labels Jul 12, 2023
@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jul 12, 2023

These are running as part of CI. No additional changes necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged Issues labeled as 'Triaged' have been reviewed and are deemed actionable.
Projects
None yet
Development

No branches or pull requests

1 participant