-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maintenance] Review use of SamlHTTPMetadataResolver #2932
Comments
[Triage] Hi @willyborankin, thank you for opening this issue. It sounds like you have done some research and that version 5 is in the works. Please follow up on what you recommend for moving forward (wait for v5 or not). |
Hi, looking into this one |
@MaciejMierzwa, thank you. The problem can be solved with OpenSAML 5.x but the minimum JDK version for it is JDK 17, since we still support JDK 11 it is not possible to move forward with it. Here is the issue about it: #3609 |
Hi @willyborankin I created draft pr for the task: #3894 |
Is your feature request related to a problem?
During review of #2927, @cwperks mentioned that the main reason of why we still use HTTP commons 4 is
SamlHTTPMetadataResolver
which reads IDP metadata file and track the state of it.The new version 4.3.0 still use HTTP commons 4 though.
What solution would you like?
To exclude HTTP commons 4 completely there are 2 options exists:
org.opensaml.saml.metadata.resolver.impl.AbstractReloadingMetadataResolver
and implement almost the same logic asorg.opensaml.saml.metadata.resolver.impl.HTTPMetadataResolver
whichSamlHTTPMetadataResolver
extends.Shibboleth
repository with new version (do not know what is the process since repo is not GiHub one)The text was updated successfully, but these errors were encountered: