Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Additional Reranker Implementations Requested #36

Closed
Tracked by #6278
macohen opened this issue Nov 23, 2022 · 5 comments
Closed
Tracked by #6278

[RFC] Additional Reranker Implementations Requested #36

macohen opened this issue Nov 23, 2022 · 5 comments
Labels
rfc Substantial changes or new features that require community input to garner consensus.

Comments

@macohen
Copy link
Collaborator

macohen commented Nov 23, 2022

We want to be sure we call ourselves out as per our principles for development. Specifically, because we are releasing this plugin with AWS Kendra as the first integrated reranker, we are unfortunately violating the "A level playing field" principle. We do see the Kendra re-ranking integration as simply the first re-ranker integration and want to add more as soon as possible. In calling this out, we are also asking the community for comments here, PRs on the plugin for additional integrations if interested, as well as cooperative work to add an additional re-ranker so we can refactor the code and generalize it.

@macohen
Copy link
Collaborator Author

macohen commented Nov 23, 2022

The background for this feature is available in #4.

@macohen macohen changed the title [RFC] AWS Kendra as First Reranker [RFC] Additional Reranker Implementations Requested Nov 23, 2022
@msfroh msfroh mentioned this issue Dec 2, 2022
5 tasks
@noCharger noCharger added the rfc Substantial changes or new features that require community input to garner consensus. label Dec 20, 2022
@jmazanec15
Copy link
Member

Hi @macohen one use case I can think of would be the ability to re-rank post query phase inside the cluster. For instance, a re-ranking plugin inside the cluster that uses ML Commons to host and execute model could be beneficial.

Would it be possible to make reranking final results after a query phase a plugin? So that implementers would not have to implement the action filter directly?

@macohen
Copy link
Collaborator Author

macohen commented Dec 27, 2022

@jmazanec15 that's the intent of the search-processor so this should fit. How do users do this with ML Commons today? Can you provide some more information so we can verify. We also do have an RFC for the overall architecture of search-processor coming in January so there should be much more to discuss then.

@jmazanec15
Copy link
Member

jmazanec15 commented Dec 27, 2022

@macohen Currently, I am not aware of any users using ml-commons to do re-ranking today. However, I could see it being extended to this use case. ML Commons provides an extendible interface for model inference workloads. (here is the client). I imagine a re-ranker plugin could be implemented that would use a reranking model hosted with ml-commons to re-rank the top K search results.

@macohen macohen removed the untriaged label Jan 18, 2023
@macohen macohen moved this from 🆕 New to 🏗 In progress in Search Project Board Jan 24, 2023
@macohen macohen moved this from 🏗 In progress to 👀 In review in Search Project Board Feb 3, 2023
@macohen
Copy link
Collaborator Author

macohen commented Feb 27, 2023

Closing. Please comment on #80 if you have ideas for additional reranker implementations.

@macohen macohen closed this as completed Feb 27, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Search Project Board Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rfc Substantial changes or new features that require community input to garner consensus.
Projects
Archived in project
Development

No branches or pull requests

3 participants